Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/display farmers statistic #77

Merged
merged 20 commits into from
Sep 18, 2019
Merged

Feat/display farmers statistic #77

merged 20 commits into from
Sep 18, 2019

Conversation

abidex4yemi
Copy link
Member

Description

  • Display all farmers statistic

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works AND the tests pass

@abidex4yemi abidex4yemi requested review from AnthonyJCampbell, daquinons and Pav0l and removed request for AnthonyJCampbell September 16, 2019 12:22
Copy link
Contributor

@AlexEntrepreneur AlexEntrepreneur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really great addition to the code! The component works well and is clearly implemented. I think with some additional CSS styles that bring this closer to the mockup this will be fully completed and ready to go.

netlify.toml Outdated Show resolved Hide resolved
src/components/pages/Dashboard/Dashboard.js Outdated Show resolved Hide resolved
@@ -23,6 +28,29 @@ const Dashboard = ({ farmers, history }) => {
}
}, [farmers]);

React.useEffect(() => {
axiosWithHeader()
.get(pathObj.getFarmersStatistic)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here it is better to create a new helper to keep the codebase consistent 👍

src/components/partials/FarmersStatistic.js Outdated Show resolved Hide resolved
src/components/partials/FarmersStatistic.js Outdated Show resolved Hide resolved
@Pav0l Pav0l merged commit 5fbda39 into master Sep 18, 2019
@Pav0l Pav0l deleted the ft-display-farmers-statistic branch September 18, 2019 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants