Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove warning logs from frontend tests #94

Merged
merged 3 commits into from
Sep 20, 2019
Merged

Remove warning logs from frontend tests #94

merged 3 commits into from
Sep 20, 2019

Conversation

daquinons
Copy link
Contributor

This fixes the way that the handler was throwing the error, which somehow was generating all the unrelated warning logs in the tests.

It also redirects to the dashboard if the changeRequest ID can't be found instead of displaying errors.

Checklist

Remove any items which are not applicable.

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works AND the tests pass

@daquinons daquinons self-assigned this Sep 20, 2019
@daquinons
Copy link
Contributor Author

@daquinons daquinons marked this pull request as ready for review September 20, 2019 14:20
@Pav0l Pav0l merged commit 4ced9ec into master Sep 20, 2019
@Pav0l Pav0l deleted the fix-test-warnings branch September 20, 2019 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants