Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adusted farmer registration input #95

Merged
merged 1 commit into from
Sep 24, 2019
Merged

adusted farmer registration input #95

merged 1 commit into from
Sep 24, 2019

Conversation

ayenisholah
Copy link
Member

Description

Describe change or new feature here.

Checklist

Remove any items which are not applicable.

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works AND the tests pass

Copy link
Member Author

@ayenisholah ayenisholah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed some commented codes on lines 658-666 and 690-698. @openwell Can you please clarify this.

@ayenisholah
Copy link
Member Author

Copy link
Contributor

@openwell openwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line 658 to 666 was meant to be an input filed. but i forgot to implement it. the logic behind it was if the cultivated crops options was not amount the listed, you can had yours. but i guess implementing it was not so easy that's why i commented it out. and forgot to return back to it. The same applies to 690-698

@openwell openwell self-requested a review September 23, 2019 13:00
@daquinons daquinons self-requested a review September 24, 2019 11:31
@daquinons daquinons merged commit 5a56836 into master Sep 24, 2019
@daquinons daquinons deleted the adjust-form branch September 24, 2019 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants