Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switched PBRemoteProgressSheet to PBTask #4

Closed

Conversation

ksuther
Copy link

@ksuther ksuther commented Feb 11, 2018

I gave this branch a try and switched PBRemoteProgressSheet to use PBTask while I was trying it out.

It also seems like the readDataToEndOfFile calls in PBTask are unnecessary since the readabilityHandler will read the data. They were throwing exceptions for me when a PBTask was run.

tiennou and others added 27 commits January 29, 2018 21:22
Task with lots of output would block when their pipe would get full. Drain our side of the pipe from time to time so the task can continue tasking.

Ref gitx#97
We might get the termination/completion notification before we actually had a chance to read anything, so we would reallocate `standardOutputData` under the readability handler.
@tiennou
Copy link
Owner

tiennou commented Feb 13, 2018

I'm really sorry. That last commit is "unwanted", because it's likely to conflict with my fix/sheets branch, which is responsible for gutting the whole concept of having a "tasked" progress sheet (see 778a7428ec30e0a3c7b19cfbcd1d7b83e3619f0e for the gory details). I'll check to see if anything can be salvaged though.

I'd gladly integrate the other two in my "branch mess" though, so ❤️ for that.

If you want to help still, here are a few pointers :

  • feature/pbtask is the new PBTask implementation
  • feature/task-wrangling is about switching GitX to use PBTask exclusively
  • wip/repo-splitting is about moving PBGitRepository out of the document hierarchy
  • fix/sheets is about simplifying the "messy" memory behavior we have w.r.t to sheets

So 1) should be complete (modulo bugs), 2) is "in-progress", 3) is in need of testing/moving around/fixing whatever is broken with document-handling (things like the age-old window restoration bug, the recent document controller that nobody ever sees, etc.), 4) should be complete and just needs some testing.

Again, I'm really sorry for not having that "upstream", but it's all a bunch of pretty large changes, and I'm not keen on having a broken master (even though it's generally quite usable, because at some time I was running on top of that fix/sheets branch without any evident issues).

@tiennou tiennou force-pushed the feature/task-wrangling branch 2 times, most recently from 1e0abc0 to 85909e5 Compare February 13, 2018 22:12
@tiennou tiennou closed this Feb 25, 2018
@ksuther ksuther deleted the feature/task-wrangling branch February 25, 2018 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants