Only store different error message on recording bug

tienvx · Apr 16, 2022 · 2b7e054 · 2b7e054
1 parent 76802f8
commit 2b7e054
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/src/Service/Bug/BugHelper.php b/src/Service/Bug/BugHelper.php
@@ -96,7 +96,9 @@ public function recordVideo(int $bugId): void
         $this->bugRepository->startRecording($bug);
         $bug->setDebug(true);
         $this->stepsRunner->run($bug->getSteps(), $bug, function (Throwable $throwable) use ($bug) {
-            $bug->getVideo()->setErrorMessage($throwable->getMessage());
+            $bug->getVideo()->setErrorMessage(
+                $throwable->getMessage() !== $bug->getMessage() ? $throwable->getMessage() : null
+            );
         });
         $this->bugRepository->stopRecording($bug);
     }

diff --git a/tests/Service/Bug/BugHelperTest.php b/tests/Service/Bug/BugHelperTest.php
@@ -72,6 +72,7 @@ protected function setUp(): void
         $this->progress->setProcessed(9);
         $this->bug = new Bug();
         $this->bug->setProgress($this->progress);
+        $this->bug->setMessage('Something wrong');
         $this->bug->setId(123);
         $this->bug->setSteps([
             $this->createMock(StepInterface::class),
@@ -257,7 +258,7 @@ public function testRecordVideo(?Throwable $exception): void
         $this->bugRepository->expects($this->once())->method('stopRecording')->with($this->bug);
         $this->helper->recordVideo(123);
         $this->assertTrue($this->bug->isDebug());
-        if ($exception) {
+        if ($exception && $exception->getMessage() !== $this->bug->getMessage()) {
             $this->assertSame($exception->getMessage(), $this->bug->getVideo()->getErrorMessage());
         } else {
             $this->assertNull($this->bug->getVideo()->getErrorMessage());
@@ -269,6 +270,7 @@ public function exceptionProvider(): array
         return [
             [null],
             [new Exception('Something wrong')],
+            [new Exception('Something else wrong')],
         ];
     }
 }