Remove testing commands

tienvx · Aug 31, 2019 · 93a23fb · 93a23fb
1 parent 8bc146b
commit 93a23fb
Show file tree

Hide file tree

Showing 39 changed files with 177 additions and 504 deletions.
diff --git a/src/Annotation/AbstractAnnotation.php b/src/Annotation/AbstractAnnotation.php
@@ -0,0 +1,29 @@
+<?php
+
+namespace Tienvx\Bundle\MbtBundle\Annotation;
+
+abstract class AbstractAnnotation
+{
+    private $name;
+
+    public function __construct(array $options)
+    {
+        if (isset($options['value'])) {
+            $options['name'] = $options['value'];
+            unset($options['value']);
+        }
+
+        foreach ($options as $key => $value) {
+            if (!property_exists($this, $key)) {
+                throw new \InvalidArgumentException(sprintf('Property "%s" does not exist', $key));
+            }
+
+            $this->$key = $value;
+        }
+    }
+
+    public function getName()
+    {
+        return $this->name;
+    }
+}
diff --git a/src/Annotation/Place.php b/src/Annotation/Place.php
@@ -9,28 +9,6 @@
  * @Annotation
  * @Target({"METHOD"})
  */
-class Place
+class Place extends AbstractAnnotation
 {
-    private $name;
-
-    public function __construct(array $options)
-    {
-        if (isset($options['value'])) {
-            $options['name'] = $options['value'];
-            unset($options['value']);
-        }
-
-        foreach ($options as $key => $value) {
-            if (!property_exists($this, $key)) {
-                throw new \InvalidArgumentException(sprintf('Property "%s" does not exist', $key));
-            }
-
-            $this->$key = $value;
-        }
-    }
-
-    public function getName()
-    {
-        return $this->name;
-    }
 }
diff --git a/src/Annotation/Subject.php b/src/Annotation/Subject.php
@@ -0,0 +1,14 @@
+<?php
+
+namespace Tienvx\Bundle\MbtBundle\Annotation;
+
+use Doctrine\Common\Annotations\Annotation;
+use Doctrine\Common\Annotations\Annotation\Target;
+
+/**
+ * @Annotation
+ * @Target({"CLASS"})
+ */
+class Subject extends AbstractAnnotation
+{
+}
diff --git a/src/Annotation/Transition.php b/src/Annotation/Transition.php
@@ -9,28 +9,6 @@
  * @Annotation
  * @Target({"METHOD"})
  */
-class Transition
+class Transition extends AbstractAnnotation
 {
-    private $name;
-
-    public function __construct(array $options)
-    {
-        if (isset($options['value'])) {
-            $options['name'] = $options['value'];
-            unset($options['value']);
-        }
-
-        foreach ($options as $key => $value) {
-            if (!property_exists($this, $key)) {
-                throw new \InvalidArgumentException(sprintf('Property "%s" does not exist', $key));
-            }
-
-            $this->$key = $value;
-        }
-    }
-
-    public function getName()
-    {
-        return $this->name;
-    }
 }
diff --git a/src/Command/SubjectTrait.php b/src/Command/SubjectTrait.php
@@ -3,7 +3,7 @@
 namespace Tienvx\Bundle\MbtBundle\Command;
 
 use Exception;
-use Tienvx\Bundle\MbtBundle\Subject\AbstractSubject;
+use Tienvx\Bundle\MbtBundle\Subject\SubjectInterface;
 use Tienvx\Bundle\MbtBundle\Subject\SubjectManager;
 
 trait SubjectTrait
@@ -16,11 +16,11 @@ trait SubjectTrait
     /**
      * @param string $model
      *
-     * @return AbstractSubject
+     * @return SubjectInterface
      *
      * @throws Exception
      */
-    protected function getSubject(string $model): AbstractSubject
+    protected function getSubject(string $model): SubjectInterface
     {
         $subject = $this->subjectManager->createSubject($model);
         $subject->setUp();

diff --git a/src/Command/TestModelCommand.php b/src/Command/TestModelCommand.php
diff --git a/src/Command/TestSubjectCommand.php b/src/Command/TestSubjectCommand.php
diff --git a/src/DependencyInjection/Compiler/GeneratorPass.php b/src/DependencyInjection/Compiler/GeneratorPass.php
@@ -9,13 +9,15 @@
 
 class GeneratorPass implements CompilerPassInterface
 {
-    use TaggedServiceTrait;
+    use PluginTrait;
 
     private $generatorService;
     private $generatorTag;
 
-    public function __construct(string $generatorService = 'mbt.generator_manager', string $generatorTag = 'mbt.generator')
-    {
+    public function __construct(
+        string $generatorService = 'mbt.generator_manager',
+        string $generatorTag = 'mbt.generator'
+    ) {
         $this->generatorService = $generatorService;
         $this->generatorTag = $generatorTag;
     }
@@ -31,7 +33,7 @@ public function process(ContainerBuilder $container)
             return;
         }
 
-        if (!$generators = $this->findTaggedServices($container, $this->generatorTag)) {
+        if (!$generators = $this->findPlugins($container, $this->generatorTag)) {
             throw new RuntimeException(sprintf('You must tag at least one service as "%s" to use the "%s" service.', $this->generatorTag, $this->generatorService));
         }
 

diff --git a/...Injection/Compiler/TaggedServiceTrait.php → ...endencyInjection/Compiler/PluginTrait.php b/...Injection/Compiler/TaggedServiceTrait.php → ...endencyInjection/Compiler/PluginTrait.php
@@ -7,18 +7,17 @@
 use Symfony\Component\DependencyInjection\ContainerBuilder;
 use Symfony\Component\DependencyInjection\Reference;
 
-trait TaggedServiceTrait
+trait PluginTrait
 {
     /**
      * @param ContainerBuilder $container
      * @param string           $tagName
-     * @param bool             $reference
      *
      * @return array
      *
      * @throws Exception
      */
-    private function findTaggedServices(ContainerBuilder $container, string $tagName, bool $reference = true)
+    private function findPlugins(ContainerBuilder $container, string $tagName)
     {
         $services = [];
         foreach ($container->findTaggedServiceIds($tagName, true) as $serviceId => $attributes) {
@@ -38,7 +37,7 @@ private function findTaggedServices(ContainerBuilder $container, string $tagName
             $support = call_user_func([$class, 'support']);
             if ($support) {
                 $serviceName = call_user_func([$class, 'getName']);
-                $services[$serviceName] = $reference ? (new Reference($serviceId)) : $class;
+                $services[$serviceName] = new Reference($serviceId);
             }
         }
 

diff --git a/src/DependencyInjection/Compiler/ReducerPass.php b/src/DependencyInjection/Compiler/ReducerPass.php
@@ -9,7 +9,7 @@
 
 class ReducerPass implements CompilerPassInterface
 {
-    use TaggedServiceTrait;
+    use PluginTrait;
 
     private $reducerService;
     private $reducerTag;
@@ -33,7 +33,7 @@ public function process(ContainerBuilder $container)
             return;
         }
 
-        if (!$reducers = $this->findTaggedServices($container, $this->reducerTag)) {
+        if (!$reducers = $this->findPlugins($container, $this->reducerTag)) {
             throw new RuntimeException(sprintf('You must tag at least one service as "%s" to use the "%s" service.', $this->reducerTag, $this->reducerService));
         }