Merge pull request #619 from tienvx/fix-missing-expression-on-import

Fix missing expression on import
tienvx · Apr 29, 2022 · e37d5e6 · e37d5e6
2 parents d514d50 + 91e1b37
commit e37d5e6
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/src/Factory/Model/Revision/TransitionFactory.php b/src/Factory/Model/Revision/TransitionFactory.php
@@ -12,6 +12,7 @@ public static function createFromArray(array $data): TransitionInterface
         $transition = new Transition();
         $transition->setLabel($data['label'] ?? '');
         $transition->setGuard($data['guard'] ?? null);
+        $transition->setExpression($data['expression'] ?? null);
         $transition->setCommands(
             array_map([CommandFactory::class, 'createFromArray'], ($data['commands'] ?? []))
         );

diff --git a/tests/Factory/Model/Revision/TransitionFactoryTest.php b/tests/Factory/Model/Revision/TransitionFactoryTest.php
@@ -20,6 +20,7 @@ protected function setUp(): void
         $this->data = [
             'label' => 'Transition 1',
             'guard' => 'count > 1',
+            'expression' => '{count: count + 1}',
             'fromPlaces' => [1, 2],
             'toPlaces' => [2, 3],
             'commands' => [],
@@ -31,6 +32,7 @@ public function testCreateFromArray(): void
         $transition = TransitionFactory::createFromArray($this->data);
         $this->assertSame('Transition 1', $transition->getLabel());
         $this->assertSame('count > 1', $transition->getGuard());
+        $this->assertSame('{count: count + 1}', $transition->getExpression());
         $this->assertSame([1, 2], $transition->getFromPlaces());
         $this->assertSame([2, 3], $transition->getToPlaces());
         $this->assertIsArray($transition->getCommands());