Merge 89d0bf0 into 31bdf06

src/Entity/Bug.php

@@ -60,6 +60,11 @@ class Bug extends BugModel
      */
     protected bool $closed = false;
 
+    /**
+     * @ORM\Column(type="boolean")
+     */
+    protected bool $recording = false;
+
     /**
      * @ORM\Column(name="created_at", type="datetime")
      */

src/Model/Bug.php

@@ -14,6 +14,7 @@ class Bug implements BugInterface
     protected string $message;
     protected ProgressInterface $progress;
     protected bool $closed = false;
+    protected bool $recording = false;
     protected DateTimeInterface $updatedAt;
     protected DateTimeInterface $createdAt;
 
@@ -100,6 +101,16 @@ public function setClosed(bool $closed): void
         $this->closed = $closed;
     }
 
+    public function isRecording(): bool
+    {
+        return $this->recording;
+    }
+
+    public function setRecording(bool $recording): void
+    {
+        $this->recording = $recording;
+    }
+
     public function setCreatedAt(DateTimeInterface $createdAt): void
     {
         $this->createdAt = $createdAt;

src/Model/BugInterface.php

@@ -40,6 +40,10 @@ public function isClosed(): bool;
 
     public function setClosed(bool $closed): void;
 
+    public function isRecording(): bool;
+
+    public function setRecording(bool $recording): void;
+
     public function setCreatedAt(DateTimeInterface $createdAt): void;
 
     public function getCreatedAt(): DateTimeInterface;

src/Repository/BugRepository.php

@@ -51,4 +51,18 @@ public function increaseTotal(BugInterface $bug, int $total): void
             $bug->getProgress()->setTotal($bug->getProgress()->getTotal() + $total);
         });
     }
+
+    public function startRecording(BugInterface $bug): void
+    {
+        $bug->setRecording(true);
+        $this->getEntityManager()->flush();
+    }
+
+    public function stopRecording(BugInterface $bug): void
+    {
+        $bug->setRecording(false);
+        // Recording bug may take long time. Reconnect to flush changes.
+        $this->getEntityManager()->getConnection()->connect();
+        $this->getEntityManager()->flush();
+    }
 }

src/Repository/BugRepositoryInterface.php

@@ -12,4 +12,8 @@ public function updateSteps(BugInterface $bug, array $newSteps): void;
     public function increaseProcessed(BugInterface $bug, int $processed = 1): void;
 
     public function increaseTotal(BugInterface $bug, int $total): void;
+
+    public function startRecording(BugInterface $bug): void;
+
+    public function stopRecording(BugInterface $bug): void;
 }

src/Service/Bug/BugHelper.php

@@ -2,6 +2,7 @@
 
 namespace Tienvx\Bundle\MbtBundle\Service\Bug;
 
+use Symfony\Component\Messenger\Exception\RecoverableMessageHandlingException;
 use Symfony\Component\Messenger\MessageBusInterface;
 use Tienvx\Bundle\MbtBundle\Entity\Bug;
 use Tienvx\Bundle\MbtBundle\Exception\ExceptionInterface;
@@ -85,7 +86,16 @@ public function reportBug(int $bugId): void
     public function recordVideo(int $bugId): void
     {
         $bug = $this->getBug($bugId, 'record video for bug');
+
+        if ($bug->isRecording()) {
+            throw new RecoverableMessageHandlingException(
+                sprintf('Can not record video for bug %d: bug is recording. Will retry later', $bug->getId())
+            );
+        }
+
+        $this->bugRepository->startRecording($bug);
         $this->stepsRunner->run($bug->getSteps(), $bug, true);
+        $this->bugRepository->stopRecording($bug);
     }
 
     public function createBug(array $steps, string $message): BugInterface

src/Service/Task/TaskHelper.php

@@ -2,8 +2,8 @@
 
 namespace Tienvx\Bundle\MbtBundle\Service\Task;
 
+use Symfony\Component\Messenger\Exception\RecoverableMessageHandlingException;
 use Throwable;
-use Tienvx\Bundle\MbtBundle\Exception\RuntimeException;
 use Tienvx\Bundle\MbtBundle\Exception\UnexpectedValueException;
 use Tienvx\Bundle\MbtBundle\Generator\GeneratorManagerInterface;
 use Tienvx\Bundle\MbtBundle\Model\Bug\StepInterface;
@@ -44,7 +44,9 @@ public function run(int $taskId): void
         }
 
         if ($task->isRunning()) {
-            throw new RuntimeException(sprintf('Can not run task %d: task is already running', $task->getId()));
+            throw new RecoverableMessageHandlingException(
+                sprintf('Can not run task %d: task is running. Will retry later', $task->getId())
+            );
         }
 
         $this->taskRepository->startRunning($task);

tests/Model/BugTest.php

@@ -45,6 +45,7 @@ protected function setUp(): void
         $this->bug->setMessage('bug message');
         $this->bug->setProgress($this->progress);
         $this->bug->setClosed(true);
+        $this->bug->setRecording(true);
     }
 
     public function testProperties(): void
@@ -56,6 +57,7 @@ public function testProperties(): void
         $this->assertSame('bug message', $this->bug->getMessage());
         $this->assertSame($this->progress, $this->bug->getProgress());
         $this->assertSame(true, $this->bug->isClosed());
+        $this->assertSame(true, $this->bug->isRecording());
     }
 
     protected function createBug(): BugInterface

tests/Repository/BugRepositoryTest.php

@@ -2,6 +2,7 @@
 
 namespace Tienvx\Bundle\MbtBundle\Tests\Repository;
 
+use Doctrine\DBAL\Connection;
 use Doctrine\DBAL\LockMode;
 use Doctrine\ORM\Decorator\EntityManagerDecorator;
 use Doctrine\ORM\Mapping\ClassMetadata;
@@ -150,4 +151,23 @@ public function testIncreaseTotal(): void
         $this->assertSame(5, $this->bug->getProgress()->getProcessed());
         $this->assertSame(13, $this->bug->getProgress()->getTotal());
     }
+
+    public function testStartRecordingBug(): void
+    {
+        $this->bug->setRecording(false);
+        $this->manager->expects($this->once())->method('flush');
+        $this->bugRepository->startRecording($this->bug);
+        $this->assertTrue($this->bug->isRecording());
+    }
+
+    public function testStopRecordingBug(): void
+    {
+        $connection = $this->createMock(Connection::class);
+        $connection->expects($this->once())->method('connect');
+        $this->bug->setRecording(true);
+        $this->manager->expects($this->once())->method('flush');
+        $this->manager->expects($this->once())->method('getConnection')->willReturn($connection);
+        $this->bugRepository->stopRecording($this->bug);
+        $this->assertFalse($this->bug->isRecording());
+    }
 }

tests/Service/Bug/BugHelperTest.php

@@ -4,6 +4,7 @@
 
 use PHPUnit\Framework\TestCase;
 use Symfony\Component\Messenger\Envelope;
+use Symfony\Component\Messenger\Exception\RecoverableMessageHandlingException;
 use Symfony\Component\Messenger\MessageBusInterface;
 use Tienvx\Bundle\MbtBundle\Entity\Bug;
 use Tienvx\Bundle\MbtBundle\Entity\Progress;
@@ -232,13 +233,24 @@ public function testRecordVideoMissingBug(): void
         $this->helper->recordVideo(123);
     }
 
+    public function testRunTaskAlreadyRunning(): void
+    {
+        $this->expectException(RecoverableMessageHandlingException::class);
+        $this->expectExceptionMessage('Can not record video for bug 123: bug is recording. Will retry later');
+        $this->bug->setRecording(true);
+        $this->bugRepository->expects($this->once())->method('find')->with(123)->willReturn($this->bug);
+        $this->helper->recordVideo(123);
+    }
+
     public function testRecordVideo(): void
     {
         $this->stepsRunner
             ->expects($this->once())
             ->method('run')
             ->with($this->bug->getSteps(), $this->bug, true);
         $this->bugRepository->expects($this->once())->method('find')->with(123)->willReturn($this->bug);
+        $this->bugRepository->expects($this->once())->method('startRecording')->with($this->bug);
+        $this->bugRepository->expects($this->once())->method('stopRecording')->with($this->bug);
         $this->helper->recordVideo(123);
     }
 }

tests/Service/Task/TaskHelperTest.php

@@ -5,10 +5,10 @@
 use Exception;
 use PHPUnit\Framework\TestCase;
 use SingleColorPetrinet\Model\Color;
+use Symfony\Component\Messenger\Exception\RecoverableMessageHandlingException;
 use Throwable;
 use Tienvx\Bundle\MbtBundle\Entity\Bug;
 use Tienvx\Bundle\MbtBundle\Entity\Task;
-use Tienvx\Bundle\MbtBundle\Exception\RuntimeException;
 use Tienvx\Bundle\MbtBundle\Exception\UnexpectedValueException;
 use Tienvx\Bundle\MbtBundle\Generator\GeneratorInterface;
 use Tienvx\Bundle\MbtBundle\Generator\GeneratorManagerInterface;
@@ -82,8 +82,8 @@ public function testRunNoTask(): void
 
     public function testRunTaskAlreadyRunning(): void
     {
-        $this->expectException(RuntimeException::class);
-        $this->expectExceptionMessage('Can not run task 123: task is already running');
+        $this->expectException(RecoverableMessageHandlingException::class);
+        $this->expectExceptionMessage('Can not run task 123: task is running. Will retry later');
         $this->task->setRunning(true);
         $this->taskRepository->expects($this->once())->method('find')->with(123)->willReturn($this->task);
         $this->taskHelper->run(123);