Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create devcontainer.json #1

Closed
wants to merge 1 commit into from
Closed

Conversation

Johnson1s
Copy link

@tienvx
Copy link
Owner

tienvx commented Mar 1, 2024

I have some questions about this change:

  • Can you explain a bit about that change? What benefits does it bring?
  • This repo is just a fork. If you want to apply this change to more people (not just me), you have to create a PR to the original repo.
  • Same as above point, the master branch is just a mirror of original repo's master branch. And I would like to keep them in sync. Can you change the target branch?
  • Why you mention that compatibility suite's PR Implement V1 Consumer scenarios in this PR? That PR is quite old. And I don't see any relation.

@tienvx
Copy link
Owner

tienvx commented Mar 6, 2024

Closing as I don't see any benefits this bring. Please reopen when this PR is ready.

@tienvx tienvx closed this Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants