Merge pull request #42 from tienvx/fix-tests-failed-with-symfony-6.1

Fix tests failed with Symfony 6.1
tienvx · Jun 30, 2022 · 56c8ed1 · 56c8ed1
2 parents 1d2cda9 + 4a8619f
commit 56c8ed1
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 6 deletions.
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
@@ -50,7 +50,7 @@ jobs:
         runs-on: ubuntu-latest
         strategy:
             matrix:
-                php-versions: ['7.4', '8.0']
+                php-versions: ['7.4', '8.0', '8.1']
                 dependencies: [ 'lowest', 'locked', 'highest' ]
         name: PHP ${{ matrix.php-versions }} with ${{ matrix.dependencies }} dependencies
         steps:

diff --git a/tests/Kernel/AppKernelTrait.php b/tests/Kernel/AppKernelTrait.php
@@ -4,12 +4,12 @@
 
 trait AppKernelTrait
 {
-    public function getCacheDir()
+    public function getCacheDir(): string
     {
         return $this->createTmpDir('cache');
     }
 
-    public function getLogDir()
+    public function getLogDir(): string
     {
         return $this->createTmpDir('logs');
     }

diff --git a/tests/Kernel/EmptyAppKernel.php b/tests/Kernel/EmptyAppKernel.php
@@ -10,7 +10,7 @@ class EmptyAppKernel extends Kernel
 {
     use AppKernelTrait;
 
-    public function registerBundles()
+    public function registerBundles(): iterable
     {
         return [new CollectionJsBundle()];
     }

diff --git a/tests/Kernel/FrameworkAppKernel.php b/tests/Kernel/FrameworkAppKernel.php
@@ -12,7 +12,7 @@ class FrameworkAppKernel extends Kernel
 {
     use AppKernelTrait;
 
-    public function registerBundles()
+    public function registerBundles(): iterable
     {
         return [new FrameworkBundle(), new CollectionJsBundle()];
     }

diff --git a/tests/Kernel/TwigAppKernel.php b/tests/Kernel/TwigAppKernel.php
@@ -14,7 +14,7 @@ class TwigAppKernel extends Kernel
 {
     use AppKernelTrait;
 
-    public function registerBundles()
+    public function registerBundles(): iterable
     {
         return [new FrameworkBundle(), new TwigBundle(), new CollectionJsBundle()];
     }