Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lttng): add FileNotFound exception when file is not found #172

Merged
merged 2 commits into from
Nov 1, 2022

Conversation

hsgwa
Copy link
Contributor

@hsgwa hsgwa commented Oct 27, 2022

Signed-off-by: hsgwa 19860128+hsgwa@users.noreply.github.comfound

Signed-off-by: hsgwa <19860128+hsgwa@users.noreply.github.com>
@hsgwa hsgwa changed the title feat(lttng): add exception when file is not found feat(lttng): add FileNotExist exception when file is not found Oct 27, 2022
@hsgwa hsgwa requested a review from keita1523 October 28, 2022 05:27
src/test/infra/lttng/test_lttng.py Outdated Show resolved Hide resolved
src/caret_analyze/infra/lttng/lttng.py Show resolved Hide resolved
@hsgwa hsgwa requested a review from keita1523 October 31, 2022 06:11
@hsgwa hsgwa force-pushed the feat_lttng_file_not_found_error branch from 1fd7ddc to d1a6225 Compare October 31, 2022 06:14
Signed-off-by: hsgwa <19860128+hsgwa@users.noreply.github.com>
@hsgwa hsgwa force-pushed the feat_lttng_file_not_found_error branch from 100ee47 to b94a9df Compare October 31, 2022 06:15
@hsgwa hsgwa changed the title feat(lttng): add FileNotExist exception when file is not found feat(lttng): add FileNotFound exception when file is not found Oct 31, 2022
Copy link
Contributor

@keita1523 keita1523 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hsgwa
LGTM

Copy link
Contributor

@takeshi-iwanari takeshi-iwanari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@takeshi-iwanari takeshi-iwanari merged commit a20f017 into tier4:main Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants