Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IDEA]: apply FlyWeight design pattern to transformation matrices #162

Open
ktro2828 opened this issue Jun 5, 2024 · 0 comments
Open

[IDEA]: apply FlyWeight design pattern to transformation matrices #162

ktro2828 opened this issue Jun 5, 2024 · 0 comments

Comments

@ktro2828
Copy link
Collaborator

ktro2828 commented Jun 5, 2024

Description

Currently, FrameGroundTruth keeps transformation matrices including sensor related, but it is static that coordinates of sensors with respect to base link. Therefore it is useless to keep those in every frame.

  • Current implementation
class FrameGroundTruth:
    ...
    transforms: TransformsDict ...including ego->map, ego->lidar, ego->camearaN,...
  • Proposal
class SceneGroundTruth:
    data_root: str
    frames: list[FrameGroundTruth]
    sensors: dict[FrameID, SensorCalibration> ...including sensor information
    
# ----------------------------------------------------------
class FrameGroundTruth:
    ...
    ego2map: HomogeneousMatrix | None

class SensorCalibration:
    frame_id: FrameID
    modality: SensorModality
    position: ArrayLike; 3
    rotation: Quaternion
    camera_intrinsic: ArrayLike; 4 | None
    camera_distortion: ArrayLike; 4 | None

Purpose

Possible approaches

Definition of done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant