Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support of filtering out objects by their orignal names or attributes #66

Merged
merged 5 commits into from
Apr 26, 2023

Conversation

ktro2828
Copy link
Collaborator

@ktro2828 ktro2828 commented Apr 17, 2023

Category

  • Perception

What

Related to #65
Add support of filtering out objects by their original label names or attributes.
Filter out by ...

  • keywords of original label names: fire -> filter out vehicle.fire
  • attributes: cycle_state.without_rider -> filter out labels with cycle_state.without_rider
config = PerceptionEvaluationConfig(
    evaluation_config_dict={
        ...
        ignore_attributes=["cycle_state.without_rider"],
        ...
    }
)

Type of change

  • New feature
  • Update test
  • Update document

Test performed

  • test.sensing_lsim



  • test.perception_lsim



Reference

Notes for reviewer

@ktro2828 ktro2828 self-assigned this Apr 17, 2023
@ktro2828 ktro2828 added the enhancement New feature or request label Apr 17, 2023
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
@ktro2828 ktro2828 changed the title feat: Add support of filtering out objects by their orignal names or attributes feat: add support of filtering out objects by their orignal names or attributes Apr 17, 2023
@ktro2828 ktro2828 marked this pull request as ready for review April 19, 2023 04:26
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
Copy link
Contributor

@hayato-m126 hayato-m126 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@hayato-m126 hayato-m126 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A PR was created to use the functionality of this branch from driving_log_replayer.
tier4/driving_log_replayer#146

Verified that it works correctly with the created PR.

Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
@ktro2828
Copy link
Collaborator Author

ktro2828 commented Apr 21, 2023

@hayato-m126

PerceptionPassFailConfigに、ignore_attributesって必要じゃないですか?

No, it does not. Objects are filtered out with paramters named CriticalObjectFilterConfig.filtering_params like this

self.critical_ground_truth_objects = filter_objects(
objects=ros_critical_ground_truth_objects,
is_gt=True,
ego2map=self.ego2map,
**self.critical_object_filter_config.filtering_params,
)

dict(
target_labels=["green", "red", "yellow", "unknown"]
if label_prefix == "traffic_light"
else ["car", "bicycle", "pedestrian", "motorbike"],
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't your suggestion syntax error?

@hayato-m126
Copy link
Contributor

Sorry. The SUGGESTION I wrote was wrong.
I have confirmed that it works correctly with the code that is implemented now.

Copy link
Contributor

@hayato-m126 hayato-m126 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yukke42 yukke42 linked an issue Apr 24, 2023 that may be closed by this pull request
@ktro2828 ktro2828 merged commit 898d0ee into develop Apr 26, 2023
20 checks passed
@ktro2828 ktro2828 deleted the feat/label-attributes branch April 26, 2023 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TODO]: Add support of label's attributes
2 participants