-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support of filtering out objects by their orignal names or attributes #66
Conversation
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
4daf334
to
92aa3e4
Compare
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PerceptionPassFailConfigに、ignore_attributesって必要じゃないですか?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A PR was created to use the functionality of this branch from driving_log_replayer.
tier4/driving_log_replayer#146
Verified that it works correctly with the created PR.
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
No, it does not. Objects are filtered out with paramters named Lines 78 to 83 in 9392d9e
|
dict( | ||
target_labels=["green", "red", "yellow", "unknown"] | ||
if label_prefix == "traffic_light" | ||
else ["car", "bicycle", "pedestrian", "motorbike"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't your suggestion syntax error?
Sorry. The SUGGESTION I wrote was wrong. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Category
What
Related to #65
Add support of filtering out objects by their original label names or attributes.
Filter out by ...
fire
-> filter outvehicle.fire
cycle_state.without_rider
-> filter out labels withcycle_state.without_rider
Type of change
Test performed
Reference
Notes for reviewer