-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(perception)!: add support of perception FP validation #78
Conversation
1678498
to
144fdce
Compare
7caeacb
to
23bade4
Compare
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
…ions and add deprecated warnings to old functions Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
…ether label is annotated for FP Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
…jects Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
…il result Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
… task Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
23bade4
to
57bfced
Compare
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
6f4989a
to
caf90b8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
estimated_objects is array
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
@@ -70,9 +71,11 @@ class PerceptionEvaluationConfig(_EvaluationConfigBase): | |||
"detection2d", | |||
"tracking2d", | |||
"classification2d", | |||
"fp_validation2d", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since fp_validation2d is defined, don't we need an implementation example test/perceiotin_fp_validat_lsim2d.py?
Co-authored-by: Hayato Mizushima <hayato-m126@users.noreply.github.com>
… specified Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR works with tier4/driving_log_replayer#200
Category
What
Related to #76
Add support of False Positive validation.
[New features]
max_matchable_radii
.MatchingStatus
GroundTruthStatus
.get_object_status(...) -> List[GroundTruthStatus]
returns list of status info for each GT.Sample output by
test/perception_fp_validataion_lsim.py
Type of change
[DEPRECATED]
The old one will be removed in next minor update -> 1.2.0
evaluation/matching/objects_filter.py
divide_tp_fp_objects(...)
get_positive_objects(...)
get_fn_objects(...)
get_negative_objects(...)
_is_fn_objects(...)
Test performed
Reference
Notes for reviewer