Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(caret/words): add libpcre #93

Merged
merged 2 commits into from
Jun 21, 2024
Merged

Conversation

tier4-autoware-public-bot[bot]
Copy link
Contributor

@tier4-autoware-public-bot tier4-autoware-public-bot bot commented Jun 21, 2024

libpcre3, a package name of ubuntu.
https://packages.ubuntu.com/jammy/libpcre3

related: https://github.com/tier4/caret_trace/actions/runs/9594718166/job/26457902714

But it has already added at tier4/autoware-spell-check-dict#740. I apologize for any trouble I've caused you.

Signed-off-by: GitHub <noreply@github.com>
@tier4-autoware-public-bot tier4-autoware-public-bot bot merged commit 39a0c45 into main Jun 21, 2024
5 checks passed
@tier4-autoware-public-bot tier4-autoware-public-bot bot deleted the add-word-libpcre branch June 21, 2024 07:39
@HansRobo
Copy link
Collaborator

HansRobo commented Jun 21, 2024

@nabetetsu @takam5f2
Please complete the TODOs in the PR description when merging the PR.
I'll look forward to your cooperation.

@HansRobo
Copy link
Collaborator

The word are related to cppcheck workflow?
In fact, these words would cause errors even if in the CARET but also other repositorues, so I had already added them to autoware-spell-check-dict.

libpcre: tier4/autoware-spell-check-dict#740
nproc: tier4/autoware-spell-check-dict#739

@takam5f2
Copy link
Contributor

@nabetetsu
Could you fill the reason why you wanted to add the words? Best,

@takam5f2
Copy link
Contributor

takam5f2 commented Jun 24, 2024

@HansRobo

The word are related to cppcheck workflow?

Yes, we have introduced cppcheck but some unknown words were detected.

In fact, these words would cause errors even if in the CARET but also other repositorues, so I had already added them to autoware-spell-check-dict.

Thank you for letting me know it.

@takam5f2
Copy link
Contributor

@HansRobo
I'd like to remove nproc from our dictionary.
libpcre3 was added, but libpcre is not added so far. On the other hand, nproc was added.

libpcre: tier4/autoware-spell-check-dict#740
nproc: tier4/autoware-spell-check-dict#739

Thank you for your follow.

@nabetetsu
Copy link
Contributor

@HansRobo @takam5f2 Sorry for my delay response. I have updated description of this PR.
I apologize for any trouble I've caused you.

nabetetsu added a commit that referenced this pull request Jun 24, 2024
Signed-off-by: Tetsuo Watanabe <tetsuo.watanabe@tier4.jp>
takam5f2 pushed a commit that referenced this pull request Jun 24, 2024
Revert "feat(caret/words): add libpcre #93"

Signed-off-by: Tetsuo Watanabe <tetsuo.watanabe@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants