feat(perception): update perception criteria #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
hayato-m126
requested changes
Oct 6, 2023
driving_log_replayer/driving_log_replayer/criteria/perception.py
Outdated
Show resolved
Hide resolved
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
Co-authored-by: Hayato Mizushima <hayato-m126@users.noreply.github.com>
hayato-m126
approved these changes
Oct 6, 2023
There was a problem hiding this comment.
LGTM
I confirmed this PR woks fine with the dataset below.
https://tier4.github.io/driving_log_replayer/quick_start/perception/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of PR
Description
Update criteria for perception evaluation.
After this PR, users can choose criteria from the following two options.
num_tp... Based on the number of the TP(or TN) objectsmetrics_score... Based on classification accuracy for classification task or mAP for the othersIn a scenario file,
See the details of definition -> TIER IV INTERNAL LINK
How to review this PR
Others