feat: add caret record CLI #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hsgwa <19860128+hsgwa@users.noreply.github.com>
|
I checked this PR ran correctly. |
keita1523
previously approved these changes
Oct 10, 2022
ros2caret/verb/record.py
Outdated
| base_path=args.path, | ||
| ros_events=events_ust, | ||
| kernel_events=events_kernel, | ||
| context_fields=context_fields, |
There was a problem hiding this comment.
Runtime error occurs in Galactic (Ubuntu 20.04), because ros2_tracing in Galactic uses context_names instead of context_fields
There was a problem hiding this comment.
@takeshi-iwanari
Thank you for pointing out!
fixed in: c3c3e98
Signed-off-by: hsgwa <19860128+hsgwa@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: hsgwa 19860128+hsgwa@users.noreply.github.com
This PR add new CLI:
This is just a wrapper of following:
ros2 trace -k -u "ros*"I'm planning to add some features to
ros2 caret recordros2 run caret_trace clock_recorder.