Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color code characters showing up on copied text #35

Closed
Fluboxer opened this issue Aug 14, 2023 · 2 comments
Closed

Color code characters showing up on copied text #35

Fluboxer opened this issue Aug 14, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@Fluboxer
Copy link

Long story short - I saw spike of activity and commits, got my hands on sources and compiled most recent version 3a1cd35 into a jar and then got it in my client to see if it fixed stuff. It did! Mostly... (more on that later)

2023-08-14_13 10 27

However, while I was testing stuff, I missclicked on screenshot taken message and it crashed minecraft. After few more tests I found out that it can be reproduced reliably - just take screenshot and try to copy message about screenshot
No idea if it is from new commits or it was always here

изображение

Other mods:
[✔] 1.19-fullbright-1.0.2
[✔] borderless-mining-1.1.8+1.20.1
[✔] c2me-fabric-mc1.20.1-0.2.0+alpha.10.96
[✔] cloth-config-11.1.106-fabric
[✔] coordinatelist-1.5.0-1.20
[✔] dashloader-5.0.0-beta.1+1.20.0
[✔] Debugify-1.20.1+2.0
[✔] dulkirmod-fabric-1.0.1
[✔] enhancedblockentities-0.9+1.20
[✔] entityculling-fabric-1.6.2-mc1.20
[✔] fabric-api-0.86.1+1.20.1
[✔] fabric-language-kotlin-1.10.8+kotlin.1.9.0
[✔] ferritecore-6.0.0-fabric
[✔] ImmediatelyFast-1.1.27+1.20.1
[✔] indium-1.0.21+mc1.20.1
[✔] language-reload-1.5.8+1.20.1
[✔] lazydfu-0.1.3
[✔] lithium-fabric-mc1.20.1-0.11.2
[✔] memoryleakfix-fabric-1.17+-1.1.1
[✔] midnightlib-fabric-1.4.1.1
[✔] modelfix-1.14-fabric
[✔] modmenu-7.2.1
[✔] moreculling-1.20-0.18.1
[✔] MouseTweaks-fabric-mc1.20-2.25
[✔] NoChatReports-FABRIC-1.20.1-v2.2.2
[✔] skyblocker-1.11.1-beta-053dd6f+1.20.1
[✔] sodium-extra-0.4.25+mc1.20.1-build.108
[✔] sodium-fabric-mc1.20-0.4.10+build.27
[✔] yet-another-config-lib-fabric-3.1.0+1.20
[✔] Zoomify-2.11.0

crash-2023-08-14_13.16.39-client.txt

@Fluboxer
Copy link
Author

I probably should make new issues with those but I will wait for release to do so

new version fixed almost everything... keyword - almost. Most things that were mess before fix are now nice, but there are few messages that STILL have part of color coding in it. Can't tell difference from console

I'm personally somewhat fine with it - most messages players copy in my use-case (skill, collection, other player's messages, compact/pristine/refined procs, ah/bz messages) are fixed. In fact, I couldn't find other message where it would get messy color codes apart from this one message about profile you are playing on

2023-08-14_13 10 20
2023-08-14_13 10 27

also anti-spam still able to do this (in both cases I clicked on test message)
изображение
изображение

@tierrif tierrif added the bug Something isn't working label Sep 4, 2023
@tierrif tierrif changed the title Crash when attempted to copy "screenshot taken" message Color code characters showing up on copied text Feb 5, 2024
@tierrif
Copy link
Owner

tierrif commented Feb 5, 2024

At this point this is a duplicate of #29.

@tierrif tierrif closed this as not planned Won't fix, can't repro, duplicate, stale Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants