This repository has been archived by the owner on Jan 2, 2024. It is now read-only.
api: report 400 if plan or feature not found #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isaacs
approved these changes
Jan 9, 2023
| // TERR1010: org or features problem | ||
| // TERR2000: internal errors | ||
| var errorLookup = map[error]*trweb.HTTPError{ | ||
| control.ErrOrgNotFound: { | ||
| Status: 400, |
There was a problem hiding this comment.
400 is fine, but sort of feels like these "not found" errors should be 404s?
LGTM, just a bikeshed.
There was a problem hiding this comment.
If I POST /v1/schedule it's a 400, and I think it should stay that, but we can change it to a 404 for /v1/whoami if it is not that way already.
Previously, the API would return a 500 if the user supplied a non-existent feature or plan. There is more work to do on error reporting, but this commit provides clarity to the user with a clear error message. Fixes #211
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the API would return a 500 if the user supplied a non-existent feature or plan.
There is more work to do on error reporting, but this commit provides clarity to the user with a clear error message.
Fixes #211