This repository has been archived by the owner on Jan 2, 2024. It is now read-only.
control: be more aware of test clocks #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a bug with test clocks where customer IDs were cached based only on the org ID, not by test clocks. This resulted in invalid cache hits due to org name collisions if the same org name was used across test clocks because the first customer ID would be cached and then used in requests targeting different clocks where the customer ID did not exist. This also narrows the list of returned customers by Stripe to those in a test clock, if any.
bmizerany
force-pushed
the
testclockfixes
branch
from
d7a9846
to
73bf184
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a bug with test clocks where customer IDs were cached
based only on the org ID, not by test clocks. This resulted in invalid
cache hits due to org name collisions if the same org name was used
across test clocks, because the first customer ID would be cached and
then used in requests targeting different clocks where the customer ID
did not exist.
This also narrows the list of returned customers by Stripe to those in a
test clock, if any.