This repository has been archived by the owner on Jan 2, 2024. It is now read-only.
control: fix bug when scheduling from subscription #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when scheduling from a subscription, we would send 'now' as the start of the first phase, which Stripe would interpret as "update current period start date to 'now'", which is illegal. Instead, we now send the current period start date as the start of the first phase we get back after creating the schedule from the subscription.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when scheduling from a subscription, we would send 'now'
as the start of the first phase, which Stripe would interpret as "update
current period start date to 'now'", which is illegal. Instead, we now
send the current period start date as the start of the first phase we
get back after creating the schedule from the subscription.