This repository has been archived by the owner on Jan 2, 2024. It is now read-only.
all: use slices mirror package #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmizerany
force-pushed
the
mirrorslices
branch
from
16385a5
to
1f2f846
Compare
This commit "vendors" and uses a copy of the slices package just before changeing the SlicesFunc signature to require an int return vs a bool. By vendoring, we avoid updating our code (for now) and requiring a forced upgrade to go1.21 for anyone not yet ready for that. Fixes #306
bmizerany
force-pushed
the
mirrorslices
branch
from
1f2f846
to
559de5d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit "vendors" and uses a copy of the slices package just before
changeing the SlicesFunc signature to require an int return vs a bool.
By vendoring, we avoid updating our code (for now) and requiring a
forced upgrade to go1.21 for anyone not yet ready for that.
Fixes #306