Skip to content
This repository has been archived by the owner on Mar 8, 2019. It is now read-only.

Fix space key event issue with Japanese, Chinese (etc) IMEs in Chrome and Safari #382

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

muan
Copy link

@muan muan commented May 4, 2013

This should fix #177 where when space bar is hit, the unfinished characters got inserted and interrupted the process of typing, choosing words.

The problem being, in Chrome and Safari, keyup event of SPACE_KEY will be triggered during the process of typing in IMEs that require choosing words before entering; however, in Firefox, keyup event of SPACE_KEY will NOT be triggered during such process, which is the ideal behaviour.
Therefore simply changing keyup to keydown solves the problem. Tested in Chrome and Safari, keydown events of SPACE_KEY would not be triggered during typing, and the behaviour in Firefox stays the same. 😊

@vietqhoang
Copy link

Thanks for investigating this muan!

Looks like it works!

@muan
Copy link
Author

muan commented May 11, 2013

@vietqhoang Thanks for the confirmation! 😄
Looks like they haven't been merging things in for a long time though. 😕

@takashi
Copy link

takashi commented Sep 28, 2013

👍

@nappa
Copy link

nappa commented Oct 9, 2013

👍 why not merge?

@smilkobuta
Copy link

Nice work!! Thank you.

@2no
Copy link

2no commented Mar 13, 2014

Thank you!!

@num87
Copy link

num87 commented Mar 13, 2014

Thank you!!!!!!!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Japanese IME Input Issue
7 participants