Issues: tiffanywang3/acme
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Author
Label
Projects
Milestones
Assignee
Sort
Issues list
Build recommendation engine (see workshop) - update hash when we process a checkout?
in progress
#80
opened Nov 5, 2015 by
codebyuma
Update cart tests to put the createCart in a beforeEach. Can change the error handlers at the end of your tests to .then(null, done) - ex on line 111. OR use Chai-As-Promised to return the result of the it and you can get rid of the dones and mocha will handle the error if the promise fails
#78
opened Nov 4, 2015 by
codebyuma
Update carts routes - for the put and post, refactor out some of the shared code. Consider using router.param and deal with the findIndex stuff. Also consider putting a lot of the long stuff into the model and reference the method in the route. , for the PUT, have the productID in the route. Update the delete route to use _.remove or _.pull? -
#75
opened Nov 4, 2015 by
codebyuma
Update products routers to move the search code into a model static and call that (ie. Product.openSearch(req.query)). Also consider using {$regex:'xyz'}. Also consider updating our get all route to just do Product.find(req.query) instead of ones at the end of the file.
#74
opened Nov 4, 2015 by
codebyuma
Update user routes to use router.param to deal with findbyid and make our code DRY
#70
opened Nov 4, 2015 by
codebyuma
ProTip!
What’s not been updated in a month: updated:<2024-04-09.