This repository has been archived by the owner on Apr 13, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 8
[BUG] Condition value is always package weight and never subtotal (except if package has no weight) #28
Comments
The following patch can be used to quick-fix this:
Add it to Composer:
|
Thank you for submitting this fix, we will investigate this further and make adjustments where needed. My colleague looked at your fix and said the following, a small adjustment you can make is: Thank you again for bringing this to our attention we will investigate the issue! Have a great day, |
Same issue on Mage 2.4.3-p1. Fix worked wonders, thanks! |
Hi @vandijkstef, Thank you for your confirmation! Have a great day, |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
To Reproduce
Steps to reproduce the behavior:
Expected result
The shipping costs is 0
Actual result
The shipping costs is 3.95
Workaround
Change \TIG\GLS\Model\ResourceModel\Carrier\bindings, line 152:
Old:
$bindings[':condition_value'] = $request->getPackageWeight();
New:
$bindings[':condition_value'] = $this->getConditionValue($request->getAllItems());
Note:
Because of the following line:
if ($bindings[':condition_name'] == null && $bindings[':condition_value'] == 0.0)
It does seem to work when no weight is set for the product.
Screenshots
Shipping rates:
Settings:
The text was updated successfully, but these errors were encountered: