Added defaults parameters, solved initialization bug that causes crash

Signed-off-by: Fabiano Riccardi <fabiuz4@hotmail.it>
tig · Mar 20, 2019 · 82a6853 · 82a6853
1 parent 55a1971
commit 82a6853
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/Fsm.cpp b/Fsm.cpp
@@ -26,8 +26,9 @@ State::State(void (*on_enter)(), void (*on_state)(), void (*on_exit)())
 
 Fsm::Fsm(State* initial_state)
 : m_current_state(initial_state),
-  m_transitions(NULL),
+  m_transitions(nullptr),
   m_num_transitions(0),
+  m_timed_transitions(nullptr),
   m_num_timed_transitions(0),
   m_initialized(false)
 {

diff --git a/Fsm.h b/Fsm.h
@@ -26,7 +26,7 @@
 
 struct State
 {
-  State(void (*on_enter)(), void (*on_state)(), void (*on_exit)());
+  State(void (*on_enter)(), void (*on_state)() = nullptr, void (*on_exit)() = nullptr);
   void (*on_enter)();
   void (*on_state)();
   void (*on_exit)();
@@ -40,10 +40,10 @@ class Fsm
   ~Fsm();
 
   void add_transition(State* state_from, State* state_to, int event,
-                      void (*on_transition)());
+                      void (*on_transition)() = nullptr);
 
   void add_timed_transition(State* state_from, State* state_to,
-                            unsigned long interval, void (*on_transition)());
+                            unsigned long interval, void (*on_transition)() = nullptr);
 
   void check_timed_transitions();