Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: full async + cjs (no build need) #41

Merged
merged 4 commits into from May 9, 2022
Merged

Conversation

devthejo
Copy link
Contributor

@devthejo devthejo commented May 5, 2022

No description provided.

@nake89
Copy link
Contributor

nake89 commented May 5, 2022

Very nice! Thank you. I'll look into this soon :)

@nake89
Copy link
Contributor

nake89 commented May 9, 2022

I've been testing this and it looks good to me.
That said. I noticed that this breaks compatibility with node v8. Node 10 still works for this.
But that is not a supported version of node anyway. Even node 12 is ending it's maintenance support. So in my opinion this is definitely good enough.

I just need to update the read me to mirror this. Currently it says that version 10 is supported.

I will merge this pull request.

@nake89 nake89 merged commit 5453806 into tiged:main May 9, 2022
@nake89
Copy link
Contributor

nake89 commented May 9, 2022

I will publish new version soon.

@nake89
Copy link
Contributor

nake89 commented May 9, 2022

New version published.

@devthejo
Copy link
Contributor Author

Thank you very much for your reactivity and for the great job on this tool !
Best regards :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants