Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated '-netAdapterName' argument from Install-Containerd.ps1 invocation #1357

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

coutinhop
Copy link
Member

Product Version(s):

Issue:

Link to docs preview:

SME review:

  • An SME has approved this change.

DOCS review:

  • A member of the docs team has approved this change.

Additional information:

Merge checklist:

  • Deploy preview inspected wherever changes were made
  • Build completed successfully
  • Test have passed

@coutinhop coutinhop requested a review from a team as a code owner March 6, 2024 21:37
Copy link

netlify bot commented Mar 6, 2024

Deploy Preview for calico-docs-preview-next ready!

Name Link
🔨 Latest commit 2775b08
🔍 Latest deploy log https://app.netlify.com/sites/calico-docs-preview-next/deploys/65e8e212f189ad0008839f41
😎 Deploy Preview https://deploy-preview-1357--calico-docs-preview-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 57 (🟢 up 7 from production)
Accessibility: 93 (no change from production)
Best Practices: 92 (no change from production)
SEO: 79 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 6, 2024

Deploy Preview succeeded!

Built without sensitive environment variables

Name Link
🔨 Latest commit 2775b08
🔍 Latest deploy log https://app.netlify.com/sites/tigera/deploys/65e8e2124c25320008fed300
😎 Deploy Preview https://deploy-preview-1357--tigera.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 45 (🔴 down 22 from production)
Accessibility: 93 (no change from production)
Best Practices: 83 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@frozenprocess frozenprocess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@frozenprocess
Copy link
Contributor

kubernetes-sigs/sig-windows-tools@03dbf15#diff-3ece5b12add9b610f12075fb08040f96b5c968f3ecb39ac5892bb33c11fecf1dL15 <- corresponding removal.

@ctauchen
Copy link
Collaborator

ctauchen commented Mar 7, 2024

LGTM

@ctauchen ctauchen merged commit f7d100f into tigera:main Mar 7, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants