Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH#7127 Add CRD upgrade to helm upgrade instructions #637

Merged
merged 1 commit into from
May 9, 2023

Conversation

lwr20
Copy link
Member

@lwr20 lwr20 commented May 9, 2023

Product Version(s):

Calico, all versions.

Issue:

projectcalico/calico#7127

Link to docs preview:

SME review:

  • An SME has approved this change.

DOCS review:

  • A member of the docs team has approved this change.

Additional information:

This is a port of an old PR from the projectcalico/calico repo from before the docs got moved.

Merge checklist:

  • Deploy preview inspected wherever changes were made
  • Build completed successfully
  • Tests have passed

@lwr20 lwr20 requested a review from a team as a code owner May 9, 2023 13:45
@netlify
Copy link

netlify bot commented May 9, 2023

Deploy Preview succeeded! Please check the logs for test failures which will cause the production (main) build to fail.

Built without sensitive environment variables

Name Link
🔨 Latest commit 95be201
🔍 Latest deploy log https://app.netlify.com/sites/tigera/deploys/645a630e4532430008f9bf55
😎 Deploy Preview https://deploy-preview-637--tigera.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@bmckercher123 bmckercher123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lwr20 there is a formatting issue with these. Rebase and squash commits and I will approve.

image

@lwr20 lwr20 merged commit dbcdebd into tigera:main May 9, 2023
4 checks passed
@lwr20 lwr20 deleted the lwr-helm-upgrade-crds branch May 9, 2023 15:54
Copy link

@aquam8 aquam8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants