Skip to content

Commit

Permalink
Mount legacy SSL_CERT_FILE in system-wide trust store
Browse files Browse the repository at this point in the history
This changeset mounts the default `SSL_CERT_FILE` to system-wide trust
store under `/etc/pki/tls/cert.pem` for applications linking legacy
libssl.
  • Loading branch information
hjiawei committed Feb 18, 2023
1 parent f1ea88b commit 5c74178
Show file tree
Hide file tree
Showing 35 changed files with 204 additions and 199 deletions.
7 changes: 3 additions & 4 deletions pkg/controller/apiserver/apiserver_controller_test.go
@@ -1,4 +1,4 @@
// Copyright (c) 2020-2022 Tigera, Inc. All rights reserved.
// Copyright (c) 2020-2023 Tigera, Inc. All rights reserved.

// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -46,7 +46,6 @@ import (
rmeta "github.com/tigera/operator/pkg/render/common/meta"
"github.com/tigera/operator/pkg/render/common/secret"
"github.com/tigera/operator/pkg/tls"
"github.com/tigera/operator/pkg/tls/certificatemanagement"
"github.com/tigera/operator/test"
)

Expand Down Expand Up @@ -212,9 +211,9 @@ var _ = Describe("apiserver controller tests", func() {
MountPath: fmt.Sprintf("/%s", packetCaptureSecret.Name),
},
{
Name: certificatemanagement.TrustedCertConfigMapName,
Name: "tigera-ca-bundle",
ReadOnly: true,
MountPath: certificatemanagement.TrustedCertVolumeMountPath,
MountPath: "/etc/pki/tls/certs",
},
}))
csrinitContainer := test.GetContainer(pcDeployment.Spec.Template.Spec.InitContainers, "tigera-packetcapture-server-tls-key-cert-provisioner")
Expand Down
24 changes: 13 additions & 11 deletions pkg/controller/certificatemanager/certificatemanager_test.go
@@ -1,4 +1,4 @@
// Copyright (c) 2021-2022 Tigera, Inc. All rights reserved.
// Copyright (c) 2021-2023 Tigera, Inc. All rights reserved.

// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
Expand All @@ -25,6 +25,7 @@ import (

. "github.com/onsi/ginkgo"
. "github.com/onsi/gomega"

"github.com/openshift/library-go/pkg/crypto"

operatorv1 "github.com/tigera/operator/api/v1"
Expand All @@ -42,7 +43,6 @@ import (
apps "k8s.io/api/apps/v1"
batchv1 "k8s.io/api/batch/v1"
corev1 "k8s.io/api/core/v1"
v1 "k8s.io/api/core/v1"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
k8sruntime "k8s.io/apimachinery/pkg/runtime"
"sigs.k8s.io/controller-runtime/pkg/client"
Expand Down Expand Up @@ -80,7 +80,7 @@ var _ = Describe("Test CertificateManagement suite", func() {
err := apis.AddToScheme(scheme)
Expect(err).NotTo(HaveOccurred())

Expect(v1.SchemeBuilder.AddToScheme(scheme)).ShouldNot(HaveOccurred())
Expect(corev1.SchemeBuilder.AddToScheme(scheme)).ShouldNot(HaveOccurred())
Expect(apps.SchemeBuilder.AddToScheme(scheme)).ShouldNot(HaveOccurred())
Expect(batchv1.SchemeBuilder.AddToScheme(scheme)).ShouldNot(HaveOccurred())

Expand Down Expand Up @@ -463,21 +463,23 @@ var _ = Describe("Test CertificateManagement suite", func() {
By("creating and validating a trusted certificate bundle")
trustedBundle := certificateManager.CreateTrustedBundle(cert, cert2, byo, legacy)
Expect(trustedBundle.Volume()).To(Equal(corev1.Volume{
Name: certificatemanagement.TrustedCertConfigMapName,
Name: "tigera-ca-bundle",
VolumeSource: corev1.VolumeSource{
ConfigMap: &corev1.ConfigMapVolumeSource{
LocalObjectReference: corev1.LocalObjectReference{Name: certificatemanagement.TrustedCertConfigMapName},
LocalObjectReference: corev1.LocalObjectReference{Name: "tigera-ca-bundle"},
},
},
}))
Expect(trustedBundle.VolumeMount(rmeta.OSTypeLinux)).To(Equal(corev1.VolumeMount{
Name: certificatemanagement.TrustedCertConfigMapName,
MountPath: certificatemanagement.TrustedCertVolumeMountPath,
ReadOnly: true,
Expect(trustedBundle.VolumeMounts(rmeta.OSTypeLinux)).To(Equal([]corev1.VolumeMount{
{
Name: "tigera-ca-bundle",
MountPath: "/etc/pki/tls/certs",
ReadOnly: true,
},
}))
Expect(trustedBundle.MountPath()).To(Equal(certificatemanagement.TrustedCertBundleMountPath))
configMap := trustedBundle.ConfigMap(appNs)
Expect(configMap.ObjectMeta).To(Equal(metav1.ObjectMeta{Name: certificatemanagement.TrustedCertConfigMapName, Namespace: appNs}))
Expect(configMap.ObjectMeta).To(Equal(metav1.ObjectMeta{Name: "tigera-ca-bundle", Namespace: appNs}))
Expect(configMap.TypeMeta).To(Equal(metav1.TypeMeta{Kind: "ConfigMap", APIVersion: "v1"}))
By("counting the number of pem blocks in the configmap")
bundle := configMap.Data[certificatemanagement.TrustedCertConfigMapKeyName]
Expand All @@ -498,7 +500,7 @@ var _ = Describe("Test CertificateManagement suite", func() {
trustedBundle, err := certificateManager.CreateTrustedBundleWithSystemRootCertificates()
Expect(err).NotTo(HaveOccurred())
configMap := trustedBundle.ConfigMap(appNs)
Expect(configMap.ObjectMeta).To(Equal(metav1.ObjectMeta{Name: certificatemanagement.TrustedCertConfigMapName, Namespace: appNs}))
Expect(configMap.ObjectMeta).To(Equal(metav1.ObjectMeta{Name: "tigera-ca-bundle", Namespace: appNs}))
Expect(configMap.TypeMeta).To(Equal(metav1.TypeMeta{Kind: "ConfigMap", APIVersion: "v1"}))
By("counting the number of pem blocks in the configmap")
bundle := configMap.Data[certificatemanagement.RHELRootCertificateBundleName]
Expand Down
3 changes: 1 addition & 2 deletions pkg/controller/installation/core_controller_test.go
Expand Up @@ -60,7 +60,6 @@ import (
"github.com/tigera/operator/pkg/render/common/secret"
"github.com/tigera/operator/pkg/render/monitor"
"github.com/tigera/operator/pkg/tls"
"github.com/tigera/operator/pkg/tls/certificatemanagement"
"github.com/tigera/operator/test"
)

Expand Down Expand Up @@ -876,7 +875,7 @@ var _ = Describe("Testing core-controller installation", func() {
secret := &corev1.Secret{}
cfgMap := &corev1.ConfigMap{}

Expect(c.Get(ctx, client.ObjectKey{Name: certificatemanagement.TrustedCertConfigMapName, Namespace: common.CalicoNamespace}, cfgMap)).ShouldNot(HaveOccurred())
Expect(c.Get(ctx, client.ObjectKey{Name: "tigera-ca-bundle", Namespace: common.CalicoNamespace}, cfgMap)).ShouldNot(HaveOccurred())
Expect(cfgMap.GetOwnerReferences()).To(HaveLen(1))

Expect(c.Get(ctx, client.ObjectKey{Name: render.NodeTLSSecretName, Namespace: common.OperatorNamespace()}, secret)).ShouldNot(HaveOccurred())
Expand Down
2 changes: 1 addition & 1 deletion pkg/render/amazoncloudintegration.go
Expand Up @@ -317,7 +317,7 @@ func (c *amazonCloudIntegrationComponent) container() corev1.Container {
PeriodSeconds: 10,
FailureThreshold: 3,
},
VolumeMounts: []corev1.VolumeMount{c.cfg.TrustedBundle.VolumeMount(c.SupportedOSType())},
VolumeMounts: c.cfg.TrustedBundle.VolumeMounts(c.SupportedOSType()),
}
}

Expand Down
3 changes: 2 additions & 1 deletion pkg/render/amazoncloudintegration_test.go
Expand Up @@ -156,7 +156,8 @@ var _ = Describe("AmazonCloudIntegration rendering tests", func() {
}
Expect(container.VolumeMounts).To(Equal(
[]corev1.VolumeMount{
{Name: "tigera-ca-bundle", MountPath: "/etc/pki/tls/certs/", ReadOnly: true},
{Name: "tigera-ca-bundle", MountPath: "/etc/pki/tls/certs", ReadOnly: true},
{Name: "tigera-ca-bundle", MountPath: "/etc/pki/tls/cert.pem", SubPath: "ca-bundle.crt", ReadOnly: true},
}))
Expect(d.Spec.Template.Spec.Volumes).To(Equal(
[]corev1.Volume{
Expand Down
2 changes: 1 addition & 1 deletion pkg/render/apiserver.go
Expand Up @@ -1023,7 +1023,7 @@ func (c *apiServerComponent) queryServerContainer() corev1.Container {
c.cfg.TLSKeyPair.VolumeMount(c.SupportedOSType()),
}
if c.cfg.TrustedBundle != nil {
volumeMounts = append(volumeMounts, c.cfg.TrustedBundle.VolumeMount(c.SupportedOSType()))
volumeMounts = append(volumeMounts, c.cfg.TrustedBundle.VolumeMounts(c.SupportedOSType())...)
}

container := corev1.Container{
Expand Down
2 changes: 1 addition & 1 deletion pkg/render/apiserver_test.go
Expand Up @@ -291,7 +291,7 @@ var _ = Describe("API server rendering tests (Calico Enterprise)", func() {
Expect(d.Spec.Template.Spec.Containers[1].VolumeMounts[0].MountPropagation).To(BeNil())
Expect(d.Spec.Template.Spec.Containers[1].VolumeMounts[0].SubPathExpr).To(Equal(""))
Expect(d.Spec.Template.Spec.Containers[1].VolumeMounts[1].Name).To(Equal("tigera-ca-bundle"))
Expect(d.Spec.Template.Spec.Containers[1].VolumeMounts[1].MountPath).To(Equal("/etc/pki/tls/certs/"))
Expect(d.Spec.Template.Spec.Containers[1].VolumeMounts[1].MountPath).To(Equal("/etc/pki/tls/certs"))
Expect(d.Spec.Template.Spec.Containers[1].VolumeMounts[1].ReadOnly).To(BeTrue())
Expect(d.Spec.Template.Spec.Containers[1].VolumeMounts[1].SubPath).To(Equal(""))
Expect(d.Spec.Template.Spec.Containers[1].VolumeMounts[1].MountPropagation).To(BeNil())
Expand Down
26 changes: 10 additions & 16 deletions pkg/render/compliance.go
Expand Up @@ -401,9 +401,7 @@ func (c *complianceComponent) complianceControllerDeployment() *appsv1.Deploymen
},
},
SecurityContext: securitycontext.NewNonRootContext(),
VolumeMounts: []corev1.VolumeMount{
c.cfg.TrustedBundle.VolumeMount(c.SupportedOSType()),
},
VolumeMounts: c.cfg.TrustedBundle.VolumeMounts(c.SupportedOSType()),
}, c.cfg.ESClusterConfig.ClusterName(), ElasticsearchComplianceControllerUserSecret, c.cfg.ClusterDomain, c.SupportedOSType()),
},
Volumes: []corev1.Volume{
Expand Down Expand Up @@ -533,10 +531,10 @@ func (c *complianceComponent) complianceReporterPodTemplate() *corev1.PodTemplat
},
// On OpenShift reporter needs privileged access to write compliance reports to host path volume
SecurityContext: securitycontext.NewRootContext(c.cfg.Openshift),
VolumeMounts: []corev1.VolumeMount{
{MountPath: "/var/log/calico", Name: "var-log-calico"},
c.cfg.TrustedBundle.VolumeMount(c.SupportedOSType()),
},
VolumeMounts: append(
c.cfg.TrustedBundle.VolumeMounts(c.SupportedOSType()),
corev1.VolumeMount{MountPath: "/var/log/calico", Name: "var-log-calico"},
),
}, c.cfg.ESClusterConfig.ClusterName(), ElasticsearchComplianceReporterUserSecret, c.cfg.ClusterDomain, c.SupportedOSType()), c.cfg.ESClusterConfig.Replicas(), c.cfg.ESClusterConfig.Shards(),
),
},
Expand Down Expand Up @@ -755,12 +753,10 @@ func (c *complianceComponent) complianceServerPodSecurityPolicy() *policyv1beta1
}

func (c *complianceComponent) complianceServerVolumeMounts() []corev1.VolumeMount {
mounts := []corev1.VolumeMount{
c.cfg.TrustedBundle.VolumeMount(c.SupportedOSType()),
return append(
c.cfg.TrustedBundle.VolumeMounts(c.SupportedOSType()),
c.cfg.ComplianceServerCertSecret.VolumeMount(c.SupportedOSType()),
}

return mounts
)
}

func (c *complianceComponent) complianceServerVolumes() []corev1.Volume {
Expand Down Expand Up @@ -879,9 +875,7 @@ func (c *complianceComponent) complianceSnapshotterDeployment() *appsv1.Deployme
},
},
SecurityContext: securitycontext.NewNonRootContext(),
VolumeMounts: []corev1.VolumeMount{
c.cfg.TrustedBundle.VolumeMount(c.SupportedOSType()),
},
VolumeMounts: c.cfg.TrustedBundle.VolumeMounts(c.SupportedOSType()),
}, c.cfg.ESClusterConfig.ClusterName(), ElasticsearchComplianceSnapshotterUserSecret, c.cfg.ClusterDomain, c.SupportedOSType()), c.cfg.ESClusterConfig.Replicas(), c.cfg.ESClusterConfig.Shards(),
),
},
Expand Down Expand Up @@ -981,8 +975,8 @@ func (c *complianceComponent) complianceBenchmarkerDaemonSet() *appsv1.DaemonSet
{Name: "etc-systemd", MountPath: "/etc/systemd", ReadOnly: true},
{Name: "etc-kubernetes", MountPath: "/etc/kubernetes", ReadOnly: true},
{Name: "usr-bin", MountPath: "/usr/local/bin", ReadOnly: true},
c.cfg.TrustedBundle.VolumeMount(c.SupportedOSType()),
}
volMounts = append(volMounts, c.cfg.TrustedBundle.VolumeMounts(c.SupportedOSType())...)

vols := []corev1.Volume{
{
Expand Down
25 changes: 12 additions & 13 deletions pkg/render/compliance_test.go
Expand Up @@ -41,7 +41,6 @@ import (
rtest "github.com/tigera/operator/pkg/render/common/test"
"github.com/tigera/operator/pkg/render/testutils"
"github.com/tigera/operator/pkg/tls"
"github.com/tigera/operator/pkg/tls/certificatemanagement"
)

var _ = Describe("compliance rendering tests", func() {
Expand Down Expand Up @@ -345,17 +344,17 @@ var _ = Describe("compliance rendering tests", func() {
Expect(dpComplianceServer.Spec.Template.Spec.Containers[0].Env).Should(ContainElements(
corev1.EnvVar{Name: "ELASTIC_INDEX_SUFFIX", Value: "cluster"},
))
Expect(len(dpComplianceServer.Spec.Template.Spec.Containers[0].VolumeMounts)).To(Equal(2))
Expect(dpComplianceServer.Spec.Template.Spec.Containers[0].VolumeMounts[0].Name).To(Equal(certificatemanagement.TrustedCertConfigMapName))
Expect(dpComplianceServer.Spec.Template.Spec.Containers[0].VolumeMounts[0].MountPath).To(Equal(certificatemanagement.TrustedCertVolumeMountPath))
Expect(dpComplianceServer.Spec.Template.Spec.Containers[0].VolumeMounts).To(HaveLen(2))
Expect(dpComplianceServer.Spec.Template.Spec.Containers[0].VolumeMounts[0].Name).To(Equal("tigera-ca-bundle"))
Expect(dpComplianceServer.Spec.Template.Spec.Containers[0].VolumeMounts[0].MountPath).To(Equal("/etc/pki/tls/certs"))
Expect(dpComplianceServer.Spec.Template.Spec.Containers[0].VolumeMounts[1].Name).To(Equal(render.ComplianceServerCertSecret))
Expect(dpComplianceServer.Spec.Template.Spec.Containers[0].VolumeMounts[1].MountPath).To(Equal("/tigera-compliance-server-tls"))

Expect(len(dpComplianceServer.Spec.Template.Spec.Volumes)).To(Equal(2))
Expect(dpComplianceServer.Spec.Template.Spec.Volumes).To(HaveLen(2))
Expect(dpComplianceServer.Spec.Template.Spec.Volumes[0].Name).To(Equal(render.ComplianceServerCertSecret))
Expect(dpComplianceServer.Spec.Template.Spec.Volumes[0].Secret.SecretName).To(Equal(render.ComplianceServerCertSecret))
Expect(dpComplianceServer.Spec.Template.Spec.Volumes[1].Name).To(Equal(certificatemanagement.TrustedCertConfigMapName))
Expect(dpComplianceServer.Spec.Template.Spec.Volumes[1].ConfigMap.Name).To(Equal(certificatemanagement.TrustedCertConfigMapName))
Expect(dpComplianceServer.Spec.Template.Spec.Volumes[1].Name).To(Equal("tigera-ca-bundle"))
Expect(dpComplianceServer.Spec.Template.Spec.Volumes[1].ConfigMap.Name).To(Equal("tigera-ca-bundle"))

clusterRole := rtest.GetResource(resources, "tigera-compliance-server", "", rbac, "v1", "ClusterRole").(*rbacv1.ClusterRole)
Expect(clusterRole.Rules).To(ConsistOf([]rbacv1.PolicyRule{
Expand Down Expand Up @@ -584,7 +583,7 @@ var _ = Describe("compliance rendering tests", func() {
dsBenchMarker := rtest.GetResource(resources, "compliance-benchmarker", ns, "apps", "v1", "DaemonSet").(*appsv1.DaemonSet)
volumeMounts := dsBenchMarker.Spec.Template.Spec.Containers[0].VolumeMounts

Expect(len(volumeMounts)).To(Equal(6))
Expect(volumeMounts).To(HaveLen(6))

Expect(volumeMounts[0].Name).To(Equal("var-lib-etcd"))
Expect(volumeMounts[0].MountPath).To(Equal("/var/lib/etcd"))
Expand All @@ -596,8 +595,8 @@ var _ = Describe("compliance rendering tests", func() {
Expect(volumeMounts[3].MountPath).To(Equal("/etc/kubernetes"))
Expect(volumeMounts[4].Name).To(Equal("usr-bin"))
Expect(volumeMounts[4].MountPath).To(Equal("/usr/local/bin"))
Expect(volumeMounts[5].Name).To(Equal(certificatemanagement.TrustedCertConfigMapName))
Expect(volumeMounts[5].MountPath).To(Equal(certificatemanagement.TrustedCertVolumeMountPath))
Expect(volumeMounts[5].Name).To(Equal("tigera-ca-bundle"))
Expect(volumeMounts[5].MountPath).To(Equal("/etc/pki/tls/certs"))
})

It("should render benchmarker properly for GKE environments", func() {
Expand All @@ -609,7 +608,7 @@ var _ = Describe("compliance rendering tests", func() {
dsBenchMarker := rtest.GetResource(resources, "compliance-benchmarker", ns, "apps", "v1", "DaemonSet").(*appsv1.DaemonSet)
volumeMounts := dsBenchMarker.Spec.Template.Spec.Containers[0].VolumeMounts

Expect(len(volumeMounts)).To(Equal(7))
Expect(volumeMounts).To(HaveLen(7))

Expect(volumeMounts[0].Name).To(Equal("var-lib-etcd"))
Expect(volumeMounts[0].MountPath).To(Equal("/var/lib/etcd"))
Expand All @@ -621,8 +620,8 @@ var _ = Describe("compliance rendering tests", func() {
Expect(volumeMounts[3].MountPath).To(Equal("/etc/kubernetes"))
Expect(volumeMounts[4].Name).To(Equal("usr-bin"))
Expect(volumeMounts[4].MountPath).To(Equal("/usr/local/bin"))
Expect(volumeMounts[5].Name).To(Equal(certificatemanagement.TrustedCertConfigMapName))
Expect(volumeMounts[5].MountPath).To(Equal(certificatemanagement.TrustedCertVolumeMountPath))
Expect(volumeMounts[5].Name).To(Equal("tigera-ca-bundle"))
Expect(volumeMounts[5].MountPath).To(Equal("/etc/pki/tls/certs"))
Expect(volumeMounts[6].Name).To(Equal("home-kubernetes"))
Expect(volumeMounts[6].MountPath).To(Equal("/home/kubernetes"))
})
Expand Down
6 changes: 5 additions & 1 deletion pkg/render/dex.go
Expand Up @@ -205,6 +205,10 @@ func (c *dexComponent) deployment() client.Object {
}
annotations[c.cfg.TLSKeyPair.HashAnnotationKey()] = c.cfg.TLSKeyPair.HashAnnotationValue()

mounts := c.cfg.DexConfig.RequiredVolumeMounts()
mounts = append(mounts, c.cfg.TLSKeyPair.VolumeMount(c.SupportedOSType()))
mounts = append(mounts, c.cfg.TrustedBundle.VolumeMounts(c.SupportedOSType())...)

d := &appsv1.Deployment{
TypeMeta: metav1.TypeMeta{Kind: "Deployment", APIVersion: "apps/v1"},
ObjectMeta: metav1.ObjectMeta{
Expand Down Expand Up @@ -248,7 +252,7 @@ func (c *dexComponent) deployment() client.Object {
ContainerPort: DexPort,
},
},
VolumeMounts: append(c.cfg.DexConfig.RequiredVolumeMounts(), c.cfg.TLSKeyPair.VolumeMount(c.SupportedOSType()), c.cfg.TrustedBundle.VolumeMount(c.SupportedOSType())),
VolumeMounts: mounts,
},
},
Volumes: append(c.cfg.DexConfig.RequiredVolumes(), c.cfg.TLSKeyPair.Volume(), trustedBundleVolume(c.cfg.TrustedBundle)),
Expand Down
3 changes: 2 additions & 1 deletion pkg/render/dex_test.go
Expand Up @@ -70,7 +70,8 @@ var _ = Describe("dex rendering tests", func() {
{Name: "config", MountPath: "/etc/dex/baseCfg", ReadOnly: true},
{Name: "secrets", MountPath: "/etc/dex/secrets", ReadOnly: true},
{Name: "tigera-dex-tls", MountPath: "/tigera-dex-tls", ReadOnly: true},
{Name: "tigera-ca-bundle", MountPath: "/etc/pki/tls/certs/", ReadOnly: true},
{Name: "tigera-ca-bundle", MountPath: "/etc/pki/tls/certs", ReadOnly: true},
{Name: "tigera-ca-bundle", MountPath: "/etc/pki/tls/cert.pem", SubPath: "ca-bundle.crt", ReadOnly: true},
}

var expectedVolumes = []corev1.Volume{
Expand Down
4 changes: 2 additions & 2 deletions pkg/render/fluentd.go
Expand Up @@ -68,7 +68,7 @@ const (
SplunkFluentdCertificateSecretName = "logcollector-splunk-public-certificate"
SplunkFluentdSecretCertificateKey = "ca.pem"
SplunkFluentdSecretsVolName = "splunk-certificates"
SplunkFluentdDefaultCertDir = "/etc/ssl/splunk/"
SplunkFluentdDefaultCertDir = "/etc/pki/splunk/"
SplunkFluentdDefaultCertPath = SplunkFluentdDefaultCertDir + SplunkFluentdSecretCertificateKey
SysLogPublicCADir = "/etc/pki/tls/certs/"
SysLogPublicCertKey = "ca-bundle.crt"
Expand Down Expand Up @@ -544,7 +544,7 @@ func (c *fluentdComponent) container() corev1.Container {
})
}

volumeMounts = append(volumeMounts, c.cfg.TrustedBundle.VolumeMount(c.SupportedOSType()))
volumeMounts = append(volumeMounts, c.cfg.TrustedBundle.VolumeMounts(c.SupportedOSType())...)

if c.cfg.MetricsServerTLS != nil {
volumeMounts = append(volumeMounts, c.cfg.MetricsServerTLS.VolumeMount(c.SupportedOSType()))
Expand Down
2 changes: 1 addition & 1 deletion pkg/render/fluentd_test.go
Expand Up @@ -625,7 +625,7 @@ var _ = Describe("Tigera Secure Fluentd rendering tests", func() {
{"SPLUNK_PROTOCOL", "https", "", ""},
{"SPLUNK_FLUSH_INTERVAL", "5s", "", ""},
{"SPLUNK_HEC_TOKEN", "", "logcollector-splunk-credentials", "token"},
{"SPLUNK_CA_FILE", "/etc/ssl/splunk/ca.pem", "", ""},
{"SPLUNK_CA_FILE", "/etc/pki/splunk/ca.pem", "", ""},
}
for _, expected := range expectedEnvs {
if expected.val != "" {
Expand Down
14 changes: 4 additions & 10 deletions pkg/render/guardian.go
Expand Up @@ -337,16 +337,10 @@ func (c *GuardianComponent) container() []corev1.Container {
}

func (c *GuardianComponent) volumeMounts() []corev1.VolumeMount {
mounts := []corev1.VolumeMount{
c.cfg.TrustedCertBundle.VolumeMount(c.SupportedOSType()),
{
Name: GuardianVolumeName,
MountPath: "/certs/",
ReadOnly: true,
},
}

return mounts
return append(
c.cfg.TrustedCertBundle.VolumeMounts(c.SupportedOSType()),
corev1.VolumeMount{Name: GuardianVolumeName, MountPath: "/certs/", ReadOnly: true},
)
}

func (c *GuardianComponent) annotations() map[string]string {
Expand Down

0 comments on commit 5c74178

Please sign in to comment.