Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typha autoscaler should exclude Fargate Nodes in node count #2592

Open
tscn opened this issue Apr 20, 2023 · 0 comments
Open

Typha autoscaler should exclude Fargate Nodes in node count #2592

tscn opened this issue Apr 20, 2023 · 0 comments
Labels
good first issue Good for newcomers

Comments

@tscn
Copy link

tscn commented Apr 20, 2023

Expected Behavior

As Fargate nodes cannot run calico-node, they should not be included in the node count that is used for Typha autoscaling.
Seems there is logic for a similar thing in AKS in place: https://github.com/tigera/operator/blob/master/pkg/controller/installation/typha_autoscaler.go#L243

Current Behavior

Typha autoscaler includes Fargate nodes when calculating schedulable nodes.

Possible Solution

Exclude nodes with label eks.amazonaws.com/compute-type=fargate in func (t *typhaAutoscaler) getNodeCounts() (int, int, error)

Context

I currently have 2 Fargate pods/nodes in my cluster that are running Karpenter and once Karpenter will scale out and add 3
additional nodes to the cluster, typha will scale to 3 instances and prevent a consolidation to less instances.

Your Environment

  • CSP: AWS
  • Service: EKS
  • K8s version: 1.24
  • Tigera Operator: v1.29.0
@tmjd tmjd added the good first issue Good for newcomers label Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants