Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add L7 access in RBAC and syslog types #1008

Merged
merged 1 commit into from Dec 15, 2020
Merged

Add L7 access in RBAC and syslog types #1008

merged 1 commit into from Dec 15, 2020

Conversation

mgleung
Copy link
Contributor

@mgleung mgleung commented Dec 2, 2020 •
edited by doublek

Description

Add the relevant RBAC and syslog types for L7 logs.

For PR author

  • Tests for change.
  • If changing pkg/apis/, run make gen-files
  • If changing versions, run make gen-versions

For PR reviewers

A note for code reviewers - all pull requests must have the following:

  • Milestone set according to targeted release.
  • Appropriate labels:
    • kind/bug if this is a bugfix.
    • kind/enhancement if this is a a new feature.
    • enterprise if this PR applies to Calico Enterprise only.

@marvin-tigera marvin-tigera added this to the v1.14.0 milestone Dec 2, 2020
@mgleung mgleung requested a review from tmjd December 2, 2020 20:37
@mgleung mgleung added docs-not-required enterprise Feature applies to enterprise only kind/enhancement New feature or request and removed docs-pr-required labels Dec 2, 2020
doublek
doublek approved these changes Dec 14, 2020
View reviewed changes
Copy link
Contributor

@doublek doublek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mgleung mgleung merged commit 04ab897 into tigera:master Dec 15, 2020
@mgleung mgleung deleted the add-l7-rbac branch December 15, 2020 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doublek doublek doublek approved these changes

@tmjd tmjd Awaiting requested review from tmjd

Assignees
No one assigned
Labels
docs-not-required enterprise Feature applies to enterprise only kind/enhancement New feature or request release-note-required
Projects
None yet
Milestone
v1.14.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mgleung @doublek @marvin-tigera