Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable healthcheck on es client #1100

Merged

Conversation

Suraiya-Hameed
Copy link
Contributor

@Suraiya-Hameed Suraiya-Hameed commented Jan 28, 2021

Description

Elasticsearch client hits context deadline if health check is enabled,

"msg":"Elastic connect failed, retrying","error":"Head "https://tigera-secure-es-http.tigera-elasticsearch.svc.cluster.local:9200\": context deadline exceeded"

olivere/elastic#484
olivere/elastic#880

Disabling the Healthcheck, as we are already handling the case where we check for dead connection and re-create it.

For PR author

  • Tests for change.
  • If changing pkg/apis/, run make gen-files
  • If changing versions, run make gen-versions

For PR reviewers

A note for code reviewers - all pull requests must have the following:

  • Milestone set according to targeted release.
  • Appropriate labels:
    • kind/bug if this is a bugfix.
    • kind/enhancement if this is a a new feature.
    • enterprise if this PR applies to Calico Enterprise only.

Healthcheck context runs into a timeout for elasticsearch client.
Copy link
Member

@rene-dekker rene-dekker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Suraiya-Hameed
Copy link
Contributor Author

/merge-when-ready

@marvin-tigera
Copy link
Contributor

OK, I will merge the pull request when it's ready, leave the commits as is when I merge it, and leave the branch after I've merged it.

Copy link
Member

@tmjd tmjd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marvin-tigera marvin-tigera merged commit be78736 into tigera:master Jan 28, 2021
@Suraiya-Hameed Suraiya-Hameed deleted the disable-healthcheck-es-client branch January 28, 2021 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants