Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master] Fix handling of custom manager TLS certs (#1108) #1112

Merged
merged 1 commit into from
Jan 29, 2021

Conversation

lmm
Copy link
Contributor

@lmm lmm commented Jan 29, 2021

Description

Pick of #1108

For PR author

  • Tests for change.
  • If changing pkg/apis/, run make gen-files
  • If changing versions, run make gen-versions

For PR reviewers

A note for code reviewers - all pull requests must have the following:

  • Milestone set according to targeted release.
  • Appropriate labels:
    • kind/bug if this is a bugfix.
    • kind/enhancement if this is a a new feature.
    • enterprise if this PR applies to Calico Enterprise only.

Fix handling of custom manager TLS certs. We should not require the manager cert to have any specific DNS name.
Copy link
Contributor

@bcreane bcreane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cherry pick looks fine.

@bcreane bcreane merged commit 3f7d6f3 into tigera:master Jan 29, 2021
@lmm lmm modified the milestones: v1.16.0, v1.14.0 Jan 30, 2021
@lmm lmm deleted the lmm-pick branch January 30, 2021 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants