Add annotation hashes for Manager / KB to roll pods over on kb cert c… #1119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmm
approved these changes
Jan 30, 2021
| @@ -109,6 +109,8 @@ const ( | |||
| EsManagerRoleBinding = "es-manager" | |||
| EsKubeControllerRole = "es-calico-kube-controllers" | |||
| EsKubeControllerRoleBinding = "es-calico-kube-controllers" | |||
|
|
|||
| KibanaTLSAnnotationHash = "hash.operator.tigera.io/tls-certificate-secret" | |||
There was a problem hiding this comment.
nit: maybe there could be better names for the variable and value - they don't really line up well
There was a problem hiding this comment.
Could we use hash.operator.tigera.io/kibana-secrets here too?
tmjd
approved these changes
Jan 30, 2021
There was a problem hiding this comment.
The changes look good, I'd like to see consistency in the naming though. (I know the operator isn't very consistent with some names but it won't get better if we don't try 😀 )
For expediency I'm going to approve, fixing the names isn't required and if you fix it I don't need to review it again.
tmjd
added
docs-not-required
enterprise
lmm
pushed a commit
to lmm/operator
that referenced
this pull request
Jan 31, 2021
Merged
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…hange
Description
For PR author
make gen-filesmake gen-versionsFor PR reviewers
A note for code reviewers - all pull requests must have the following:
kind/bugif this is a bugfix.kind/enhancementif this is a a new feature.enterpriseif this PR applies to Calico Enterprise only.