Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[master] Need to ensure internal manager TLS secret is updated (#1117) #1123

Merged
merged 1 commit into from
Feb 1, 2021
Merged

[master] Need to ensure internal manager TLS secret is updated (#1117) #1123

merged 1 commit into from
Feb 1, 2021

Conversation

lmm
Copy link
Contributor

@lmm lmm commented Jan 31, 2021

Description

Pick of #1117

For PR author

  • Tests for change.
  • If changing pkg/apis/, run make gen-files
  • If changing versions, run make gen-versions

For PR reviewers

A note for code reviewers - all pull requests must have the following:

  • Milestone set according to targeted release.
  • Appropriate labels:
    • kind/bug if this is a bugfix.
    • kind/enhancement if this is a a new feature.
    • enterprise if this PR applies to Calico Enterprise only.

@lmm
Need to ensure internal manager TLS secret is updated (tigera#1117)
2432307 
Ensure internal manager TLS secret is recreated if DNS names are invalid
@marvin-tigera marvin-tigera added this to the v1.16.0 milestone Jan 31, 2021
@lmm lmm added enterprise Feature applies to enterprise only kind/bug Something isn't working release-note-not-required and removed release-note-required labels Jan 31, 2021
bcreane
bcreane approved these changes Feb 1, 2021
View reviewed changes
Copy link
Contributor

@bcreane bcreane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cherry-pick looks good.

@lmm lmm merged commit 389a8c2 into tigera:master Feb 1, 2021
@lmm lmm deleted the lmm-pick branch February 1, 2021 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcreane bcreane bcreane approved these changes

Assignees
No one assigned
Labels
docs-pr-required enterprise Feature applies to enterprise only kind/bug Something isn't working release-note-not-required
Projects
None yet
Milestone
v1.16.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lmm @bcreane @marvin-tigera