Add eck-operator memory requests/limits to LogStorage CR. #1137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
tmjd
requested changes
Feb 4, 2021
There was a problem hiding this comment.
Looking good, I think a few additions are needed though.
In addition to some validation (see my comments) I'd also like to see UTs for the validation.
Also make sure you run make gen-files to update the CRDs and deepcopy, I pulled your branch and ran it and saw a CRD update.
vberezny
force-pushed
the
vlad-SAAS-1250-expose-memory-settings-eck-operator
branch
from
14bd363
to
e980221
Compare
tmjd
reviewed
Feb 5, 2021
vberezny
force-pushed
the
vlad-SAAS-1250-expose-memory-settings-eck-operator
branch
from
e980221
to
a580b41
Compare
vberezny
force-pushed
the
vlad-SAAS-1250-expose-memory-settings-eck-operator
branch
5 times, most recently
from
e7d884e
to
e9e5888
Compare
vberezny
force-pushed
the
vlad-SAAS-1250-expose-memory-settings-eck-operator
branch
from
e9e5888
to
3b40664
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[Bug Fix] Exposes the elastic-operator pod memory requests/limits in the LogStorage CR. This was done to allow the end user to easily get around issues with elastic-operator pod being OOM killed due to memory usage.
Tested on the local kind cluster as well as in a banzai provisioned gcp-kubeadm environment.
https://tigera.atlassian.net/browse/SAAS-1250
Corresponding Docs PR:
https://github.com/tigera/calico-private/pull/2986
For PR author
make gen-filesFor PR reviewers
A note for code reviewers - all pull requests must have the following:
kind/bugif this is a bugfix.kind/enhancementif this is a a new feature.enterpriseif this PR applies to Calico Enterprise only.