Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new common version file for projects that have release streams ou… #1150

Merged
merged 1 commit into from
Feb 10, 2021
Merged

Add new common version file for projects that have release streams ou… #1150

merged 1 commit into from
Feb 10, 2021

Conversation

Brian-McM
Copy link
Contributor

…tside of OS and EE

Description

For PR author

  • Tests for change.
  • If changing pkg/apis/, run make gen-files
  • If changing versions, run make gen-versions

For PR reviewers

A note for code reviewers - all pull requests must have the following:

  • Milestone set according to targeted release.
  • Appropriate labels:
    • kind/bug if this is a bugfix.
    • kind/enhancement if this is a a new feature.
    • enterprise if this PR applies to Calico Enterprise only.

@marvin-tigera marvin-tigera added this to the v1.16.0 milestone Feb 9, 2021
tmjd
tmjd requested changes Feb 10, 2021
View reviewed changes
Copy link
Member

@tmjd tmjd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, a few things.
A change is needed in the main.go in the root of the repo around Line 109 in the printImages code, the CommonComponents needs to be added like the Calico and Enterprise Components loops.

pkg/controller/utils/imageset/imageset.go Show resolved Hide resolved
hack/gen-versions/common.go.tpl Outdated Show resolved Hide resolved
config/common_versions.yml Outdated Show resolved Hide resolved
hack/gen-versions/common.go.tpl Outdated Show resolved Hide resolved
@Brian-McM Brian-McM force-pushed the bm-add-new-versions-file branch 2 times, most recently from 0ab7c3a to b7661c0 Compare February 10, 2021 22:04
tmjd
tmjd reviewed Feb 10, 2021
View reviewed changes
Copy link
Member

@tmjd tmjd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one final thing can you add to the RELEASING.md doc about updating calico/common_versions.yaml where we talk about the calico and enterprise ones.

@tmjd tmjd added docs-not-required kind/enhancement New feature or request and removed docs-pr-required labels Feb 10, 2021
tmjd
tmjd approved these changes Feb 10, 2021
View reviewed changes
Copy link
Member

@tmjd tmjd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Brian-McM Brian-McM force-pushed the bm-add-new-versions-file branch 3 times, most recently from 0c7ceb1 to 8278a06 Compare February 10, 2021 23:08
@Brian-McM Brian-McM merged commit a13a027 into tigera:master Feb 10, 2021
@Brian-McM Brian-McM deleted the bm-add-new-versions-file branch February 10, 2021 23:18
@Brian-McM Brian-McM mentioned this pull request Feb 11, 2021
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmjd tmjd tmjd approved these changes

Assignees
No one assigned
Labels
docs-not-required kind/enhancement New feature or request release-note-required
Projects
None yet
Milestone
v1.16.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Brian-McM @tmjd @marvin-tigera