Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a defaulting UT for zero-length IP pools #1219

Merged
merged 1 commit into from
Mar 25, 2021
Merged

Add a defaulting UT for zero-length IP pools #1219

merged 1 commit into from
Mar 25, 2021

Conversation

caseydavenport
Copy link
Member

Description

For PR author

  • Tests for change.
  • If changing pkg/apis/, run make gen-files
  • If changing versions, run make gen-versions

For PR reviewers

A note for code reviewers - all pull requests must have the following:

  • Milestone set according to targeted release.
  • Appropriate labels:
    • kind/bug if this is a bugfix.
    • kind/enhancement if this is a a new feature.
    • enterprise if this PR applies to Calico Enterprise only.

@marvin-tigera marvin-tigera added this to the v1.16.0 milestone Mar 9, 2021
@caseydavenport caseydavenport merged commit 9197734 into tigera:master Mar 25, 2021
@caseydavenport caseydavenport deleted the casey-test-no-pools branch March 25, 2021 20:22
@tmjd
Copy link
Member

tmjd commented Mar 30, 2021

Awesome, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
docs-pr-required release-note-required
Projects
None yet
Milestone
v1.16.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@caseydavenport @tmjd @marvin-tigera