Add OIDC Prompt type to Authentication spec #1238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rene-dekker
force-pushed
the
prompt-type
branch
from
8b0cff9
to
5bd0e03
Compare
tmjd
reviewed
Mar 19, 2021
| } | ||
|
|
||
| // PromptType is a value that specifies whether the identity provider prompts the end user for re-authentication and | ||
| // consent. See the RFC for more information on prompt types: https://openid.net/specs/openid-connect-core-1_0.html | ||
| type PromptType string |
There was a problem hiding this comment.
Looking at what is rendered in the API Reference, we should list the allowed values in the comment on this type.
There was a problem hiding this comment.
I still don't see the allowed values in this comment.
There was a problem hiding this comment.
Added. I used the "One of: ..." way for showing the options. This seems to have been used a lot in the recent past.
There was a problem hiding this comment.
Ok, just for my info, does the api reference do anything special with that?
rene-dekker
force-pushed
the
prompt-type
branch
from
acb2c28
to
ba99189
Compare
rene-dekker
force-pushed
the
prompt-type
branch
from
a1e7ea6
to
b42d578
Compare
rene-dekker
force-pushed
the
prompt-type
branch
from
e8535d4
to
18192c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add prompt type so certain idps can now be supported.