Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update components for Enterprise v3.5.2 #1244

Merged
merged 1 commit into from Mar 28, 2021
Merged

Update components for Enterprise v3.5.2 #1244

merged 1 commit into from Mar 28, 2021

Conversation

doublek
Copy link
Contributor

@doublek doublek commented Mar 28, 2021 •
edited

Description

Update components for upcoming Enterprise v3.5.2

For PR author

  • Tests for change.
  • If changing pkg/apis/, run make gen-files
  • If changing versions, run make gen-versions

For PR reviewers

A note for code reviewers - all pull requests must have the following:

  • Milestone set according to targeted release.
  • Appropriate labels:
    • kind/bug if this is a bugfix.
    • kind/enhancement if this is a a new feature.
    • enterprise if this PR applies to Calico Enterprise only.

@doublek doublek requested a review from bcreane March 28, 2021 19:53
@doublek doublek added enterprise Feature applies to enterprise only hold merge Do not merge labels Mar 28, 2021
@doublek doublek added this to the v1.14.3 milestone Mar 28, 2021
bcreane
bcreane approved these changes Mar 28, 2021
View reviewed changes
Copy link
Contributor

@bcreane bcreane left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@doublek
Copy link
Contributor Author

doublek commented Mar 28, 2021

Thanks for the review. helm version will be in the docs update PR.

@doublek doublek removed the hold merge Do not merge label Mar 28, 2021
@doublek doublek merged commit 29495cf into tigera:release-v1.14 Mar 28, 2021
@doublek doublek deleted the prep-enterprise-3.5.2 branch March 28, 2021 23:55
@doublek doublek mentioned this pull request Mar 28, 2021
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcreane bcreane bcreane approved these changes

Assignees
No one assigned
Labels
docs-pr-required enterprise Feature applies to enterprise only release-note-required
Projects
None yet
Milestone
v1.14.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@doublek @bcreane @marvin-tigera