Add rights to access licenkeys for kube-controller #1247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmjd
reviewed
Mar 30, 2021
| @@ -283,6 +289,14 @@ func (c *kubeControllersComponent) controllersRole() *rbacv1.ClusterRole { | |||
| Verbs: []string{"create"}, | |||
| }) | |||
| } | |||
|
|
|||
| if c.managementClusterConnection != nil { | |||
| role.Rules = append(role.Rules, rbacv1.PolicyRule{ | |||
There was a problem hiding this comment.
How does this work since the actual create/update comes from the management cluster?
Does guardian impersonate kube-controller in the managed cluster, so operator in the managed cluster needs to give kube-controller permissions to create/update the licensekeys even though the kube-controller in the managed cluster won't be doing anything with licenses.
There was a problem hiding this comment.
Yes, all API requests that pass through the tunnel use impersonation.
There was a problem hiding this comment.
That is right. Guardian impersonates ckc and for this the role should be present.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding rights to list/watch/get licensekeys from a management cluster and create/update from a managed cluster.
For PR author
make gen-filesmake gen-versionsFor PR reviewers
A note for code reviewers - all pull requests must have the following:
kind/bugif this is a bugfix.kind/enhancementif this is a a new feature.enterpriseif this PR applies to Calico Enterprise only.