Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support BGP layout ConfigMap for BGP multi-rack setups #1272

Merged
merged 12 commits into from Apr 26, 2021
Merged

Support BGP layout ConfigMap for BGP multi-rack setups #1272

merged 12 commits into from Apr 26, 2021

Conversation

nelljerram
Copy link
Member

Description

For PR author

  • Tests for change.
  • If changing pkg/apis/, run make gen-files
  • If changing versions, run make gen-versions

For PR reviewers

A note for code reviewers - all pull requests must have the following:

  • Milestone set according to targeted release.
  • Appropriate labels:
    • kind/bug if this is a bugfix.
    • kind/enhancement if this is a a new feature.
    • enterprise if this PR applies to Calico Enterprise only.

@marvin-tigera marvin-tigera added this to the v1.17.0 milestone Apr 23, 2021
@nelljerram nelljerram added enterprise Feature applies to enterprise only kind/enhancement New feature or request labels Apr 23, 2021
@nelljerram nelljerram requested a review from tmjd April 23, 2021 14:10
tmjd
tmjd reviewed Apr 23, 2021
View reviewed changes
Copy link
Member

@tmjd tmjd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think ideally I would like to have some unit tests on the render/node.go changes, but I would not object if that doesn't happen since you already have the mainline tests.

Makefile Outdated Show resolved Hide resolved
pkg/render/render.go Outdated Show resolved Hide resolved
pkg/render/node.go Show resolved Hide resolved
Neil Jerram added 8 commits April 26, 2021 10:11
Merge remote-tracking branch 'origin/master' into bgp-layout
a3fdb0c
Review markups
dba116d
Skip Enterprise-specific test unless Tigera pull secret is explicitly…
ebdc4b3 
… provided
Merge fix
2f46b56
Fix use of Skip
35d9ae0
Delete BGP layout after BGP test
2ba631a
Revert all changes made for FV testing in mainline_test.go
0d1fbf5 
I've run into tricky issues here, in that it does not seem
straightforward to run multiple FV tests, with the operator being
started multiple times.  Hence will retreat to writing UTs instead,
and may come back to improving the infrastructure in mainline_test.go.
Add UT for new function
2ec28e0
@tmjd tmjd modified the milestones: v1.17.0, v1.18.0 Apr 26, 2021
tmjd
tmjd approved these changes Apr 26, 2021
View reviewed changes
Copy link
Member

@tmjd tmjd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tmjd tmjd merged commit fc499b7 into master Apr 26, 2021
@tmjd tmjd deleted the bgp-layout branch April 26, 2021 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmjd tmjd tmjd approved these changes

Assignees
No one assigned
Labels
docs-pr-required enterprise Feature applies to enterprise only kind/enhancement New feature or request release-note-required
Projects
None yet
Milestone
v1.18.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nelljerram @tmjd @marvin-tigera