Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't migrate if the daemonset and deployments are deleting #1289

Merged
merged 1 commit into from May 5, 2021

Conversation

paulgmiller
Copy link
Contributor

Description

If calico is deployed with addonmanager there is actuall a race where addon manager will purge before operator comes up. Most of the time this seems okay. Howver if a pod is slow to terminate then the operator will migrate the deleting daemonset and nodes can get stuck pretty easily.

projectcalico/calico#4525 (comment)

Even if it's not the whole solution having operator ignore deleting daemonsets might be better than current behavior.

For PR author

  • Tests for change.
  • If changing pkg/apis/, run make gen-files
  • If changing versions, run make gen-versions

For PR reviewers

A note for code reviewers - all pull requests must have the following:

  • Milestone set according to targeted release.
  • Appropriate labels:
    • kind/bug if this is a bugfix.
    • kind/enhancement if this is a a new feature.
    • enterprise if this PR applies to Calico Enterprise only.

@CLAassistant
Copy link

CLAassistant commented May 4, 2021

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@caseydavenport caseydavenport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty reasonable to me - nice fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants