Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add init container that logs SELinux context #1538

Merged

Conversation

doublek
Copy link
Contributor

@doublek doublek commented Sep 27, 2021

Description

Add an init container that logs SELinux context of the Elasticsearch directory. This is a workaround a k8s bug where in some circumstances the main container is not started after init containers.

For PR author

  • Tests for change.
  • If changing pkg/apis/, run make gen-files
  • If changing versions, run make gen-versions

For PR reviewers

A note for code reviewers - all pull requests must have the following:

  • Milestone set according to targeted release.
  • Appropriate labels:
    • kind/bug if this is a bugfix.
    • kind/enhancement if this is a a new feature.
    • enterprise if this PR applies to Calico Enterprise only.

@marvin-tigera marvin-tigera added this to the v1.23.0 milestone Sep 27, 2021
@doublek doublek force-pushed the elastic-init-container-selinux-workaround branch from 071f554 to 177bc3d Compare September 27, 2021 21:04
@doublek doublek marked this pull request as ready for review September 27, 2021 21:22
@doublek doublek added enterprise Feature applies to enterprise only kind/bug Something isn't working labels Sep 27, 2021
Copy link
Contributor

@Brian-McM Brian-McM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@doublek doublek force-pushed the elastic-init-container-selinux-workaround branch from 177bc3d to 00191c4 Compare September 27, 2021 21:53
@doublek doublek force-pushed the elastic-init-container-selinux-workaround branch from 00191c4 to ac61c88 Compare September 27, 2021 23:28
@doublek
Copy link
Contributor Author

doublek commented Sep 27, 2021

/merge-when-ready delete-branch

@marvin-tigera
Copy link
Contributor

OK, I will merge the pull request when it's ready, leave the commits as is when I merge it, and delete the branch after I've merged it.

@marvin-tigera
Copy link
Contributor

I'm sorry but I failed delete the branch after merging the pull request.

marvin-tigera added a commit that referenced this pull request Sep 28, 2021
…tigera-release-v1.22

Automated cherry pick of #1538: Add init container that logs SELinux context
marvin-tigera added a commit that referenced this pull request Sep 28, 2021
…tigera-release-v1.21

Automated cherry pick of #1538: Add init container that logs SELinux context
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants