Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option for calico-node to run as non privileged and non root #1544

Merged
merged 1 commit into from
Oct 14, 2021
Merged

Add option for calico-node to run as non privileged and non root #1544

merged 1 commit into from
Oct 14, 2021

Conversation

mgleung
Copy link
Contributor

@mgleung mgleung commented Sep 29, 2021

Description

Adds all of the configuration changes required to run calico-node as non-root and non-privileged.

For PR author

  • Tests for change.
  • If changing pkg/apis/, run make gen-files
  • If changing versions, run make gen-versions

For PR reviewers

A note for code reviewers - all pull requests must have the following:

  • Milestone set according to targeted release.
  • Appropriate labels:
    • kind/bug if this is a bugfix.
    • kind/enhancement if this is a a new feature.
    • enterprise if this PR applies to Calico Enterprise only.

@marvin-tigera marvin-tigera added this to the v1.23.0 milestone Sep 29, 2021
@mgleung mgleung force-pushed the non-privileged-node branch 2 times, most recently from baec9fd to ccc23ee Compare September 30, 2021 17:24
lmm
lmm reviewed Oct 4, 2021
View reviewed changes
Copy link
Contributor

@lmm lmm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took a quick look and added some comments. It might be worth getting a review from someone who was involved in the design.

pkg/render/node.go Outdated Show resolved Hide resolved
api/v1/installation_types.go Show resolved Hide resolved
pkg/render/node.go Show resolved Hide resolved
pkg/render/node.go Outdated Show resolved Hide resolved
@mgleung mgleung mentioned this pull request Oct 5, 2021
Merged
3 tasks
tmjd
tmjd requested changes Oct 12, 2021
View reviewed changes
api/v1/installation_types.go Show resolved Hide resolved
pkg/render/node.go Show resolved Hide resolved
pkg/render/node.go Outdated Show resolved Hide resolved
pkg/render/node.go Show resolved Hide resolved
pkg/render/node.go Outdated Show resolved Hide resolved
pkg/render/node_test.go Outdated Show resolved Hide resolved
@mgleung mgleung force-pushed the non-privileged-node branch 2 times, most recently from e722729 to 671d13d Compare October 12, 2021 18:11
tmjd
tmjd reviewed Oct 12, 2021
View reviewed changes
pkg/controller/installation/validation.go Outdated Show resolved Hide resolved
pkg/render/node.go Show resolved Hide resolved
pkg/render/node.go Outdated Show resolved Hide resolved
caseydavenport
caseydavenport reviewed Oct 13, 2021
View reviewed changes
pkg/render/node.go Outdated Show resolved Hide resolved
tmjd
tmjd approved these changes Oct 13, 2021
View reviewed changes
Copy link
Member

@tmjd tmjd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though before you merge please squash the changes.

@mgleung mgleung mentioned this pull request Oct 14, 2021
Merged
3 tasks
@mgleung mgleung merged commit 220b37c into tigera:master Oct 14, 2021
@mgleung mgleung deleted the non-privileged-node branch October 14, 2021 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmm lmm lmm left review comments

@caseydavenport caseydavenport caseydavenport left review comments

@tmjd tmjd tmjd approved these changes

Assignees
No one assigned
Labels
docs-pr-required release-note-required
Projects
None yet
Milestone
v1.23.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mgleung @lmm @caseydavenport @tmjd @marvin-tigera