Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cherry-pick][release-v1.27] Trim lib, lib64 to necessary imports #2043

Merged
merged 1 commit into from Jun 24, 2022
Merged

[cherry-pick][release-v1.27] Trim lib, lib64 to necessary imports #2043

merged 1 commit into from Jun 24, 2022

Conversation

freecaykes
Copy link
Contributor

@freecaykes freecaykes commented Jun 23, 2022 •
edited

Description

pick #2042

For PR author

  • Tests for change.
  • If changing pkg/apis/, run make gen-files
  • If changing versions, run make gen-versions

For PR reviewers

A note for code reviewers - all pull requests must have the following:

  • Milestone set according to targeted release.
  • Appropriate labels:
    • kind/bug if this is a bugfix.
    • kind/enhancement if this is a a new feature.
    • enterprise if this PR applies to Calico Enterprise only.

@freecaykes freecaykes requested a review from a team as a code owner June 23, 2022 22:34
@marvin-tigera marvin-tigera added this to the v1.27.7 milestone Jun 23, 2022
doublek
doublek approved these changes Jun 23, 2022
View reviewed changes
Copy link
Contributor

@doublek doublek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rene-dekker rene-dekker merged commit aec103b into tigera:release-v1.27 Jun 24, 2022
rene-dekker
rene-dekker reviewed Jun 24, 2022
View reviewed changes
Copy link
Member

@rene-dekker rene-dekker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rene-dekker rene-dekker rene-dekker left review comments

@doublek doublek doublek approved these changes

Assignees
No one assigned
Labels
docs-pr-required release-note-required
Projects
None yet
Milestone
v1.27.7
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@freecaykes @doublek @rene-dekker @marvin-tigera