Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-v1.28] Allow query server talk to Prometheus #2428

Merged

Conversation

hjiawei
Copy link
Contributor

@hjiawei hjiawei commented Jan 25, 2023

Description

This changeset allows Tigera query server talk to Prometheus to retrieve historical summary data. The extra Prometheus client certificate bundle is mounted into the queryserver container. When the request is made from queryserver to Prometheus, it will use the manager service account token to do authorization. Additional RBACs are added to the manager cluster role.

Pick #2329 into release-v1.28 branch.

For PR author

  • Tests for change.
  • If changing pkg/apis/, run make gen-files
  • If changing versions, run make gen-versions

For PR reviewers

A note for code reviewers - all pull requests must have the following:

  • Milestone set according to targeted release.
  • Appropriate labels:
    • kind/bug if this is a bugfix.
    • kind/enhancement if this is a a new feature.
    • enterprise if this PR applies to Calico Enterprise only.

This changeset allows Tigera query server talk to Prometheus to retrieve
historical summary data. The extra Prometheus client certificate
bundle is mounted into the queryserver container. When the request is
made from queryserver to Prometheus, it will use the manager service
account token to do authorization. Additional RBACs are added to the
manager cluster role.
@rene-dekker
Copy link
Member

/merge-when-ready delete-branch

@marvin-tigera
Copy link
Contributor

OK, I will merge the pull request when it's ready, leave the commits as is when I merge it, and delete the branch after I've merged it.

Copy link
Member

@rene-dekker rene-dekker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@marvin-tigera marvin-tigera merged commit 3ba0838 into tigera:release-v1.28 Jan 25, 2023
@marvin-tigera
Copy link
Contributor

I'm sorry but I failed delete the branch after merging the pull request.

@hjiawei hjiawei deleted the queryserver-prom-client-128 branch January 25, 2023 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants