Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure precommit checks happen on PR code #2588

Merged
merged 1 commit into from Apr 21, 2023
Merged

Ensure precommit checks happen on PR code #2588

merged 1 commit into from Apr 21, 2023

Conversation

tmjd
Copy link
Member

@tmjd tmjd commented Apr 18, 2023

Description

For PR author

  • Tests for change.
  • If changing pkg/apis/, run make gen-files
  • If changing versions, run make gen-versions

For PR reviewers

A note for code reviewers - all pull requests must have the following:

  • Milestone set according to targeted release.
  • Appropriate labels:
    • kind/bug if this is a bugfix.
    • kind/enhancement if this is a a new feature.
    • enterprise if this PR applies to Calico Enterprise only.

@tmjd tmjd requested a review from a team as a code owner April 18, 2023 14:56
@marvin-tigera marvin-tigera added this to the v1.30.0 milestone Apr 18, 2023
@tmjd tmjd force-pushed the ci-precommit-check branch 3 times, most recently from a412598 to 9def134 Compare April 18, 2023 17:36
@tmjd tmjd merged commit b3d6ccd into tigera:master Apr 21, 2023
5 checks passed
@tmjd tmjd deleted the ci-precommit-check branch April 21, 2023 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ozdanborne ozdanborne ozdanborne approved these changes

Assignees
No one assigned
Labels
docs-pr-required release-note-required
Projects
None yet
Milestone
v1.30.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tmjd @ozdanborne @marvin-tigera