Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add egress gateway policy to API server RBAC #2600

Merged
merged 1 commit into from
Apr 24, 2023
Merged

Add egress gateway policy to API server RBAC #2600

merged 1 commit into from
Apr 24, 2023

Conversation

mazdakn
Copy link
Member

@mazdakn mazdakn commented Apr 24, 2023 •
edited
Loading

Description

Add egress gateway policy to API server RBAC. Related to https://github.com/tigera/calico-private/pull/5836

For PR author

  • Tests for change.
  • If changing pkg/apis/, run make gen-files
  • If changing versions, run make gen-versions

For PR reviewers

A note for code reviewers - all pull requests must have the following:

  • Milestone set according to targeted release.
  • Appropriate labels:
    • kind/bug if this is a bugfix.
    • kind/enhancement if this is a a new feature.
    • enterprise if this PR applies to Calico Enterprise only.

@mazdakn mazdakn requested a review from a team as a code owner April 24, 2023 20:47
@marvin-tigera marvin-tigera added this to the v1.30.0 milestone Apr 24, 2023
hjiawei
hjiawei approved these changes Apr 24, 2023
View reviewed changes
Copy link
Contributor

@hjiawei hjiawei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @mazdakn Can we get this merged and pick to v1.30 branch?

@mazdakn
Copy link
Member Author

mazdakn commented Apr 24, 2023

v1.30 PR: #2602
PTAL

@Brian-McM Brian-McM merged commit 889f28a into tigera:master Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hjiawei hjiawei hjiawei approved these changes

@Brian-McM Brian-McM Brian-McM approved these changes

Assignees
No one assigned
Labels
docs-pr-required release-note-required
Projects
None yet
Milestone
v1.30.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mazdakn @hjiawei @Brian-McM @marvin-tigera